Bug 119251 - Pass column as 4th argument to WorkerGlobalScope.onerror and Window.onerror handlers
Summary: Pass column as 4th argument to WorkerGlobalScope.onerror and Window.onerror h...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: http://www.whatwg.org/specs/web-apps/...
Keywords: BlinkMergeCandidate, WebExposed
Depends on:
Blocks: 119257
  Show dependency tree / graph
 
Reported: 2013-07-30 06:17 PDT by Chris Dumez
Modified: 2013-07-30 10:37 PDT (History)
10 users (show)

See Also:

Attachments
Patch (32.03 KB, patch)
2013-07-30 07:00 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (32.02 KB, patch)
2013-07-30 07:07 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-07-30 06:17:37 PDT 
As per the latest WebWorker specification, the WorkerGlobalScope.onerror and Window.onerror
event handlers should be given the column as fourth argument:
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#workerglobalscope
http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#onerroreventhandler

This is already supported by IE10 and Blink.

Corresponding Blink revision:
https://src.chromium.org/viewvc/blink?revision=154630&view=revision

Test case:
http://samples.msdn.microsoft.com/ietestcenter/WebWorkers/webworkers_harness.htm?url=WorkerGlobalScope_ErrorEvent_colno.htm
Comment 1 Chris Dumez 2013-07-30 07:00:15 PDT 
Created attachment 207733 [details]
Patch
Comment 2 Chris Dumez 2013-07-30 07:07:28 PDT 
Created attachment 207734 [details]
Patch
Comment 3 Geoffrey Garen 2013-07-30 09:07:50 PDT 
Comment on attachment 207734 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2013-07-30 10:37:45 PDT 
Comment on attachment 207734 [details]
Patch

Clearing flags on attachment: 207734

Committed r153480: <http://trac.webkit.org/changeset/153480>
Comment 5 WebKit Commit Bot 2013-07-30 10:37:48 PDT 
All reviewed patches have been landed.  Closing bug.