Bug 119250 - [Coordinated Graphics] Use m_ prefix only for member variable
Summary: [Coordinated Graphics] Use m_ prefix only for member variable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-30 05:35 PDT by Jae Hyun Park
Modified: 2013-07-31 09:06 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.12 KB, patch)
2013-07-30 05:37 PDT, Jae Hyun Park 		noam: review+
noam: commit-queue-
Details | Formatted Diff | Diff
Patch (3.04 KB, patch)
2013-07-30 18:15 PDT, Jae Hyun Park 		no flags Details | Formatted Diff | Diff
Patch (3.02 KB, patch)
2013-07-31 01:22 PDT, Jae Hyun Park 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-01 for mac-mountainlion (710.80 KB, application/zip)
2013-07-31 04:07 PDT, WebKit Commit Bot 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jae Hyun Park 2013-07-30 05:35:16 PDT 
Patch to follow.
Comment 1 Jae Hyun Park 2013-07-30 05:37:10 PDT 
Created attachment 207727 [details]
Patch
Comment 2 Noam Rosenthal 2013-07-30 05:48:23 PDT 
Comment on attachment 207727 [details]
Patch

can you change the class parameters to be const& while at it?
Comment 3 Jae Hyun Park 2013-07-30 18:15:25 PDT 
Created attachment 207792 [details]
Patch
Comment 4 Noam Rosenthal 2013-07-31 01:07:34 PDT 
Comment on attachment 207792 [details]
Patch

Please const& only for class types... programType and meshType are enums.
Comment 5 Jae Hyun Park 2013-07-31 01:22:46 PDT 
Created attachment 207817 [details]
Patch
Comment 6 Jae Hyun Park 2013-07-31 01:23:04 PDT 
(In reply to comment #4)
> (From update of attachment 207792 [details])
> Please const& only for class types... programType and meshType are enums.

Oops... sorry. Thanks for the review!
Comment 7 WebKit Commit Bot 2013-07-31 04:07:17 PDT 
Comment on attachment 207817 [details]
Patch

Rejecting attachment 207817 [details] from commit-queue.

New failing tests:
compositing/reflections/load-video-in-reflection.html
Full output: http://webkit-queues.appspot.com/results/1295664
Comment 8 WebKit Commit Bot 2013-07-31 04:07:19 PDT 
Created attachment 207831 [details]
Archive of layout-test-results from webkit-cq-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.3
Comment 9 WebKit Commit Bot 2013-07-31 09:06:45 PDT 
Comment on attachment 207817 [details]
Patch

Clearing flags on attachment: 207817

Committed r153523: <http://trac.webkit.org/changeset/153523>
Comment 10 WebKit Commit Bot 2013-07-31 09:06:48 PDT 
All reviewed patches have been landed.  Closing bug.