Bug 119228 - TextTrackRepresentation captions often disappear then appear again.
Summary: TextTrackRepresentation captions often disappear then appear again.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-29 15:55 PDT by Jer Noble
Modified: 2013-07-31 20:22 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.25 KB, patch)
2013-07-29 16:12 PDT, Jer Noble 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2013-07-29 15:55:18 PDT 
TextTrackRepresentation captions often disappear then appear again.
Comment 1 Jer Noble 2013-07-29 15:55:47 PDT 
<rdar://problem/14550924>
Comment 2 Jer Noble 2013-07-29 16:12:46 PDT 
Created attachment 207677 [details]
Patch
Comment 3 WebKit Commit Bot 2013-07-29 16:15:48 PDT 
Attachment 207677 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLMediaElement.h']" exit_code: 1
Source/WebCore/html/HTMLMediaElement.h:295:  The parameter name "flags" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Simon Fraser (smfr) 2013-07-29 16:16:25 PDT 
Comment on attachment 207677 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207677&action=review

> Source/WebCore/html/HTMLMediaElement.h:294
> +    enum ConfigureTextTrackDisplayFlags { DoNotAssumeVisibleTextTracksChanged, AssumeVisibleTextTracksChanged };

"Flags" make me think this is a bitmask, and then the "flags == DoNotAssumeVisibleTextTracksChanged" code seemed iffy. Not sure I like "AssumeVisibleTextTracksChanged" etc; can you change the name to something more descriptive of the impact?
Comment 5 Jer Noble 2013-07-29 17:14:28 PDT 
Committed r153448: <http://trac.webkit.org/changeset/153448>
Comment 6 Simon Fraser (smfr) 2013-07-31 20:22:29 PDT 
This broke the media/video-controls-captions-trackmenu.html test