Bug 119214 - [Automake] Introduce libJSCBindings.la
Summary: [Automake] Introduce libJSCBindings.la
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
Depends on:
Reported: 2013-07-29 04:14 PDT by Zan Dobersek
Modified: 2013-08-24 00:53 PDT (History)
3 users (show)

See Also:

Patch (62.99 KB, patch)
2013-07-29 04:23 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-07-29 04:14:29 PDT
[Automake] Introduce libJSCBindings.la
Comment 1 Zan Dobersek 2013-07-29 04:23:22 PDT
Created attachment 207640 [details]
Comment 2 Zan Dobersek 2013-07-29 04:29:03 PDT
This basically extracts what might be the JSC bindings layer into its own library.
Comment 3 Carlos Garcia Campos 2013-07-29 05:02:32 PDT
I think this is a good idea, but I find the name a bit confusing. It sounds to me like bindings for the JSC API instead of JSC DOM bindings. The GObject DOM bindings internal library is called libWebCoreDOM, which is not accurate either :-) What about libWebCoreJSDOM and libWebCoreGObjectDOM for example? This is a WebCore sub-library so I think it makes sense to have the libWebCore prefix. What do you think?
Comment 4 Zan Dobersek 2013-07-29 05:18:29 PDT
Yeah, it could use a better name:
- libWebCoreJSCDOMBindings and libWebCoreGObjectDOMBindings (long, but spot-on with the description),
- libJSCWebCoreDOMBindings and libGObjectWebCoreDOMBindings (again descriptive, compared to first proposal the 'JSC/GObject' part is switched with 'WebCore'),
- libJSCDOMBindings and libGObjectDOMBindings (loses the 'WebCore' part, if one thinks of it as a layer that's independent of WebCore),
- libJSCWebCoreBindings and libGObjectWebCoreBindings (loses the 'DOM' part, since technically.

So, basically, we should use whatever we agree on being the best and most descriptive combination of strings 'JSC', 'WebCore' and 'DOM'. :>
Comment 5 Zan Dobersek 2013-07-31 09:48:21 PDT
Building with disabled WK1, WK2 and SVG and with purged ccache, there's a ~1.8% increase in compilation time with this patch applied.
Comment 6 Zan Dobersek 2013-08-23 13:59:57 PDT
I'll pass this through, at least for now. Another library obviously just increases the build time, while the pros of introducing it are mostly purely of analytic nature.

I've filed bug #120232 about libWebCoreDOM needing a better name.