Bug 119211 – The typeof canvas-path object is "object" and not "Path"

• Status: RESOLVED
• Resolution: INVALID
• Component: Canvas

[Rashmi Shyamasundar]

The layout tests for canvas-path, expect that the function "typeof" in JS, called on a path-object should return "Path". But, it actually returns "object".
The expectations in these tests should be changed from "Path" to "object".

[Rashmi Shyamasundar]

Created attachment 207630 [details]
Patch

[Build Bot]

Comment on attachment 207630 [details]
Patch

Attachment 207630 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1241937

New failing tests:
fast/canvas/canvas-currentPath.html
fast/canvas/canvas-path-object.html

[Build Bot]

Created attachment 207641 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.4

[Dirk Schulze]

Comment on attachment 207630 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207630&action=review

> LayoutTests/fast/canvas/script-tests/canvas-currentPath.js:63
> -shouldBeType("p", "Path");
> +shouldBe("typeof p", '"object"');

The one checks the instance the other the JS type. Why not check both? Am I missing something? Why is there no layout test update needed?

[Dirk Schulze]

(In reply to comment #2)
> (From update of attachment 207630 [details])
> Attachment 207630 [details] did not pass mac-ews (mac):
> Output: http://webkit-queues.appspot.com/results/1241937
> 
> New failing tests:
> fast/canvas/canvas-currentPath.html
> fast/canvas/canvas-path-object.html

Oh there actually are updates needed.

[Build Bot]

Comment on attachment 207630 [details]
Patch

Attachment 207630 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1296074

New failing tests:
fast/canvas/canvas-currentPath.html
fast/canvas/canvas-path-object.html

[Build Bot]

Created attachment 207667 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4

[Rashmi Shyamasundar]

Sorry for the confusion. Please ignore this bug. The tests are working fine. I had to update my javascript resources for the layouttests.

[Csaba Osztrogonác]

Comment on attachment 207630 [details]
Patch

Cleared review? from attachment 207630 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).