Bug 119210 - [WIN] Add implementation for WebCore::readFromFile()
Summary: [WIN] Add implementation for WebCore::readFromFile()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-29 02:38 PDT by Patrick R. Gansterer
Modified: 2013-09-25 12:50 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.34 KB, patch)
2013-07-29 02:42 PDT, Patrick R. Gansterer 		bfulgham: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2013-07-29 02:38:26 PDT 
[WIN] Add implementation for WebCore::readFromFile()
Comment 1 Patrick R. Gansterer 2013-07-29 02:42:43 PDT 
Created attachment 207627 [details]
Patch
Comment 2 Brent Fulgham 2013-07-30 09:37:08 PDT 
Comment on attachment 207627 [details]
Patch

readFromFile is not currently used on the Windows build.  Is there a corresponding change that causes this code to be needed?
Comment 3 Patrick R. Gansterer 2013-07-30 09:38:57 PDT 
(In reply to comment #2)
> (From update of attachment 207627 [details])
> readFromFile is not currently used on the Windows build.  Is there a corresponding change that causes this code to be needed?

Not yet, but I like to port some code, which will use it.
Comment 4 Brent Fulgham 2013-07-30 10:16:25 PDT 
Comment on attachment 207627 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207627&action=review

r=me.  Please consider adding the global namespace prefix to the ReadFile method call.

> Source/WebCore/platform/win/FileSystemWin.cpp:393
> +    bool success = ReadFile(handle, data, length, &bytesRead, 0);

We prefer to say "::ReadFile" for these global WinAPI calls.
Comment 5 Patrick R. Gansterer 2013-09-23 16:25:38 PDT 
Committed r156306: <http://trac.webkit.org/changeset/156306>