Bug 119208 - [GTK] Use WTF_PLATFORM_X11 instread of GDK_WINDOWING_X11
Summary: [GTK] Use WTF_PLATFORM_X11 instread of GDK_WINDOWING_X11
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-29 01:06 PDT by ChangSeok Oh
Modified: 2013-08-29 23:04 PDT (History)
12 users (show)

See Also:

Attachments
Patch (10.91 KB, patch)
2013-07-29 01:24 PDT, ChangSeok Oh 		gustavo: review-
gustavo: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ChangSeok Oh 2013-07-29 01:06:32 PDT 
Gtk can have GDK_WINDOWING_X11 and GDK_WINDOWING_WAYLAND at the same time. So I think it would be better to use WTF_PLATFORM_X11 flag than to use GDK_WINDOWING_X11 for future wayland support.
Comment 1 ChangSeok Oh 2013-07-29 01:24:56 PDT 
Created attachment 207626 [details]
Patch
Comment 2 WebKit Commit Bot 2013-07-29 01:27:29 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Zan Dobersek 2013-07-29 03:14:23 PDT 
FWIW, I believe the future plan is to also have concurrent support for both X11 and Wayland protocols in the same build, like the GTK+ toolkit itself.
Comment 4 Gustavo Noronha (kov) 2013-07-29 06:43:33 PDT 
Comment on attachment 207626 [details]
Patch

Yeah, since the plan is to be able to enable both and select at runtime, I think this change is probably not worth it. We would need to decide how we want to decide what to enabled, for that.