Bug 11919 - Allow setting CSS values to null.
Summary: Allow setting CSS values to null.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-21 11:30 PST by Alexey Proskuryakov
Modified: 2006-12-21 12:31 PST (History)
1 user (show)

See Also:


Attachments
proposed patch (5.10 KB, patch)
2006-12-21 11:38 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff
proposed patch (5.06 KB, patch)
2006-12-21 12:17 PST, Alexey Proskuryakov
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2006-12-21 11:30:46 PST
So, I'm proposing a patch that makes assigning null values to CSS properties work again.

This doesn't match WinIE, but matches Firefox.
Comment 1 Alexey Proskuryakov 2006-12-21 11:38:01 PST
Created attachment 11954 [details]
proposed patch

args[1]->isNull() ? String() : String(args[1]->toString(exec)) doesn't look particularly good to me - do we have a better idiom?
Comment 2 Darin Adler 2006-12-21 11:41:43 PST
(In reply to comment #1)
> args[1]->isNull() ? String() : String(args[1]->toString(exec)) doesn't look
> particularly good to me - do we have a better idiom?

We do -- valueToStringWithNullCheck is the name.
Comment 3 Alexey Proskuryakov 2006-12-21 12:17:30 PST
Created attachment 11955 [details]
proposed patch

Uses valueToStringWithNullCheck(). Thank you!
Comment 4 Darin Adler 2006-12-21 12:25:34 PST
Comment on attachment 11955 [details]
proposed patch

r=me
Comment 5 Alexey Proskuryakov 2006-12-21 12:31:35 PST
Committed revision 18377.