Bug 119187 – Inset box-shadows fail to round around corners when border-radius is set in vh/vw units.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Phil LaPier]

Created attachment 207595 [details]
Screenshot of the bug

The vh and vw units produce different bugs.

They both fail to round the inset shadow along the radius of the corner.

Non-inset shadows work as expected. 

View the JSFiddle: http://jsfiddle.net/plapier/cwEAL/

Created attachment 212431 [details]
Patch

(In reply to comment #1)
> Created an attachment (id=212431) [details]
> Patch

Hi Darin. Can you please review these changes?
Have moved the function viewportPercentageValue of StyleResolver from private to public so that other properties can use it while calculating the viewport lengths.

[Darin Adler]

Comment on attachment 212431 [details]
Patch

Change looks OK, but I'm not sure there is enough test coverage.

Created attachment 212539 [details]
Patch

[Darin Adler]

Comment on attachment 212539 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212539&action=review

> Source/WebCore/css/StyleResolver.h:314
> +    int viewportPercentageValue(CSSPrimitiveValue& unit, int percentage);
>      struct RuleRange {

Why is this grouped together with RuleRange? There should at least be a blank line separating them.

Created attachment 212662 [details]
Patch

(In reply to comment #5)
> (From update of attachment 212539 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=212539&action=review
> 
> > Source/WebCore/css/StyleResolver.h:314
> > +    int viewportPercentageValue(CSSPrimitiveValue& unit, int percentage);
> >      struct RuleRange {
> 
> Why is this grouped together with RuleRange? There should at least be a blank line separating them.

Actually while merging from one workspace to another this issue came. Sorry about that.

[WebKit Commit Bot]

Comment on attachment 212662 [details]
Patch

Clearing flags on attachment: 212662

Committed r156466: <http://trac.webkit.org/changeset/156466>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.