Bug 119186 - Replace all uses of GraphicsLayer::create function with the one that takes a GraphicsLayerFactory
Summary: Replace all uses of GraphicsLayer::create function with the one that takes a ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jacky Jiang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-27 19:52 PDT by Jacky Jiang
Modified: 2013-07-27 22:13 PDT (History)
5 users (show)

See Also:

Attachments
Patch (15.08 KB, patch)
2013-07-27 20:42 PDT, Jacky Jiang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacky Jiang 2013-07-27 19:52:23 PDT 
Source/WebCore/platform/graphics/GraphicsLayer.h
 // FIXME: Replace all uses of this create function with the one that takes a GraphicsLayerFactory.
    static PassOwnPtr<GraphicsLayer> create(GraphicsLayerClient*);
http://trac.webkit.org/changeset/130072 introduced static PassOwnPtr<GraphicsLayer> create(GraphicsLayerFactory*, GraphicsLayerClient*), we should use this instead.
Comment 1 Jacky Jiang 2013-07-27 20:42:34 PDT 
Created attachment 207598 [details]
Patch

remove GraphicsLayer::create(GraphicsLayerClient*) and adapt BlackBerry, EFL, QT, Mac ports to the change
Comment 2 WebKit Commit Bot 2013-07-27 22:13:21 PDT 
Comment on attachment 207598 [details]
Patch

Clearing flags on attachment: 207598

Committed r153408: <http://trac.webkit.org/changeset/153408>
Comment 3 WebKit Commit Bot 2013-07-27 22:13:30 PDT 
All reviewed patches have been landed.  Closing bug.