Bug 119168 – Add support infrastructure for iOS WebKit port

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Daniel Bates]

Towards building and teaching our tooling about the iOS WebKit port we need add support infrastructure to webkitdirs.

[Daniel Bates]

Created attachment 207559 [details]
Patch

[Build Bot]

Comment on attachment 207559 [details]
Patch

Attachment 207559 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1243387

New failing tests:
plugins/mouse-move-over-plugin-in-frame.html
platform/mac/editing/deleting/deletionUI-single-instance.html
plugins/mouse-events.html
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html
fast/loader/javascript-url-in-object.html
http/tests/misc/submit-post-keygen.html
http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html
http/tests/inspector/inspect-element.html

[Build Bot]

Created attachment 207568 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Ryosuke Niwa]

Comment on attachment 207559 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207559&action=review

> Tools/Scripts/webkitdirs.pm:1720
> -    if (isAppleMacWebKit()) {
> +    if (isIOSWebKit()) {
> +        $inspectorResourcesDirPath = $productDir . "/WebCore.framework/inspector";
> +    } elsif (isAppleMacWebKit()) {

I would have preferred to check isIOSWebKit() inside isAppleMacWebKit().

[Build Bot]

Comment on attachment 207559 [details]
Patch

Attachment 207559 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1242526

New failing tests:
editing/selection/leak-document-with-selection-inside.html

[Build Bot]

Created attachment 207585 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3

[Daniel Bates]

(In reply to comment #4)
> (From update of attachment 207559 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207559&action=review
> 
> > Tools/Scripts/webkitdirs.pm:1720
> > -    if (isAppleMacWebKit()) {
> > +    if (isIOSWebKit()) {
> > +        $inspectorResourcesDirPath = $productDir . "/WebCore.framework/inspector";
> > +    } elsif (isAppleMacWebKit()) {
> 
> I would have preferred to check isIOSWebKit() inside isAppleMacWebKit().

Will modify patch to check isIOSWebKit() inside isAppleMacWebKit() before I land it.

[Daniel Bates]

Committed r153430: <http://trac.webkit.org/changeset/153430>