Bug 119168 - Add support infrastructure for iOS WebKit port
Summary: Add support infrastructure for iOS WebKit port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-26 15:38 PDT by Daniel Bates
Modified: 2013-07-29 09:34 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.86 KB, patch)
2013-07-26 15:44 PDT, Daniel Bates
rniwa: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (680.34 KB, application/zip)
2013-07-26 17:31 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (503.88 KB, application/zip)
2013-07-27 07:38 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2013-07-26 15:38:47 PDT
Towards building and teaching our tooling about the iOS WebKit port we need add support infrastructure to webkitdirs.
Comment 1 Daniel Bates 2013-07-26 15:44:18 PDT
Created attachment 207559 [details]
Patch
Comment 2 Build Bot 2013-07-26 17:31:22 PDT
Comment on attachment 207559 [details]
Patch

Attachment 207559 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1243387

New failing tests:
plugins/mouse-move-over-plugin-in-frame.html
platform/mac/editing/deleting/deletionUI-single-instance.html
plugins/mouse-events.html
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html
fast/loader/javascript-url-in-object.html
http/tests/misc/submit-post-keygen.html
http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html
http/tests/inspector/inspect-element.html
Comment 3 Build Bot 2013-07-26 17:31:24 PDT
Created attachment 207568 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.3
Comment 4 Ryosuke Niwa 2013-07-26 17:37:03 PDT
Comment on attachment 207559 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207559&action=review

> Tools/Scripts/webkitdirs.pm:1720
> -    if (isAppleMacWebKit()) {
> +    if (isIOSWebKit()) {
> +        $inspectorResourcesDirPath = $productDir . "/WebCore.framework/inspector";
> +    } elsif (isAppleMacWebKit()) {

I would have preferred to check isIOSWebKit() inside isAppleMacWebKit().
Comment 5 Build Bot 2013-07-27 07:38:04 PDT
Comment on attachment 207559 [details]
Patch

Attachment 207559 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1242526

New failing tests:
editing/selection/leak-document-with-selection-inside.html
Comment 6 Build Bot 2013-07-27 07:38:06 PDT
Created attachment 207585 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3
Comment 7 Daniel Bates 2013-07-29 09:14:11 PDT
(In reply to comment #4)
> (From update of attachment 207559 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207559&action=review
> 
> > Tools/Scripts/webkitdirs.pm:1720
> > -    if (isAppleMacWebKit()) {
> > +    if (isIOSWebKit()) {
> > +        $inspectorResourcesDirPath = $productDir . "/WebCore.framework/inspector";
> > +    } elsif (isAppleMacWebKit()) {
> 
> I would have preferred to check isIOSWebKit() inside isAppleMacWebKit().

Will modify patch to check isIOSWebKit() inside isAppleMacWebKit() before I land it.
Comment 8 Daniel Bates 2013-07-29 09:34:43 PDT
Committed r153430: <http://trac.webkit.org/changeset/153430>