Bug 119167 - GraphicsContext3D needs implementation on Windows
Summary: GraphicsContext3D needs implementation on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P3 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-26 15:34 PDT by Alex Christensen
Modified: 2013-07-29 14:24 PDT (History)
5 users (show)

See Also:


Attachments
Patch (10.79 KB, patch)
2013-07-26 15:40 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (1.25 MB, application/zip)
2013-07-26 23:21 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-07-26 15:34:37 PDT
GraphicsContext3D has 9 methods that are not implemented for the Apple Win port.  They're implemented for Cairo, Mac, Blackberry, Qt, and EFL, but not for the AppleWin port.  I made an implementation based on the Cairo and Mac ports, the two cousins of the AppleWin port.  It compiles and links successfully, and it's protected by USE(3D_GRAPHICS), so it won't break anything anyone is using now.
Comment 1 Alex Christensen 2013-07-26 15:40:17 PDT
Created attachment 207558 [details]
Patch
Comment 2 Build Bot 2013-07-26 23:21:13 PDT
Comment on attachment 207558 [details]
Patch

Attachment 207558 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1251422

New failing tests:
editing/unsupported-content/table-delete-003.html
editing/unsupported-content/list-type-before.html
editing/unsupported-content/table-type-before.html
editing/unsupported-content/list-delete-003.html
editing/unsupported-content/list-delete-001.html
editing/unsupported-content/list-type-after.html
editing/unsupported-content/table-delete-002.html
editing/unsupported-content/table-type-after.html
editing/unsupported-content/table-delete-001.html
Comment 3 Build Bot 2013-07-26 23:21:14 PDT
Created attachment 207577 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3
Comment 4 WebKit Commit Bot 2013-07-29 14:24:21 PDT
Comment on attachment 207558 [details]
Patch

Clearing flags on attachment: 207558

Committed r153441: <http://trac.webkit.org/changeset/153441>
Comment 5 WebKit Commit Bot 2013-07-29 14:24:24 PDT
All reviewed patches have been landed.  Closing bug.