Bug 119163 - EGL surfaces code has EFL-specific code
Summary: EGL surfaces code has EFL-specific code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P3 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-26 14:38 PDT by Alex Christensen
Modified: 2013-07-29 15:39 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2013-07-26 14:43 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (25.31 KB, patch)
2013-07-29 13:10 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-07-26 14:38:27 PDT 
Source/WebCore/platform/graphics/surfaces/egl/EGLSurface.h #includes GLTransportSurface.h, which is in Source/WebCore/platform/graphics/surfaces/efl.  The efl code should not be compiled on non-efl platforms.
Comment 1 Alex Christensen 2013-07-26 14:43:35 PDT 
Created attachment 207556 [details]
Patch
Comment 2 Kalyan 2013-07-26 15:41:10 PDT 
we can try to reuse GLTransportSurface class and GraphicsSurfaceCommon classes and move them outside efl folder.

Couple of changes needed here:
1)GLTransportSurface has a dependency on TextureMapperShaderProgram to render textures to surface. I don't know if that is going to be an issue for you (otherwise we would need to implement a shader here). 
2)GraphicsSurfaceCommon currently has support for CoordinateGraphics. We should include function platformPaintToTextureMapper only when Co-ordinatedGraphics is supported.
Comment 3 Alex Christensen 2013-07-26 15:45:18 PDT 
Comment on attachment 207556 [details]
Patch

We're going to move GLTransportSurface to Source/WebCore/platform/graphics/surfaces instead
Comment 4 Alex Christensen 2013-07-29 13:10:40 PDT 
Created attachment 207668 [details]
Patch
Comment 5 Kalyan 2013-07-29 13:15:43 PDT 
LGTM
Comment 6 WebKit Commit Bot 2013-07-29 15:39:01 PDT 
Comment on attachment 207668 [details]
Patch

Clearing flags on attachment: 207668

Committed r153443: <http://trac.webkit.org/changeset/153443>
Comment 7 WebKit Commit Bot 2013-07-29 15:39:03 PDT 
All reviewed patches have been landed.  Closing bug.