Bug 119159 - W3C Test Import script reformats test HTML
Summary: W3C Test Import script reformats test HTML
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bem Jones-Bey
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-26 14:03 PDT by Bem Jones-Bey
Modified: 2013-09-18 17:54 PDT (History)
5 users (show)

See Also:


Attachments
Patch (21.02 KB, patch)
2013-08-26 15:55 PDT, Bem Jones-Bey
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2013-07-26 14:03:00 PDT
When importing a W3C test, the import script reformats the HTML, which adds new lines and indentation. In some cases, this can break tests. The importer should not change the formatting of tests that it imports.
Comment 1 Bem Jones-Bey 2013-07-31 17:17:09 PDT
It looks like it may also break inline styles, so that should be tested for along with this fix,
Comment 2 Bem Jones-Bey 2013-08-26 15:55:01 PDT
Created attachment 209685 [details]
Patch

Rewrite test conversion to miminimize reformatting when rewriting tests.
Comment 3 Dirk Pranke 2013-08-26 16:07:11 PDT
Hm, I was hoping this would be a simple patch, but it isn't, and so I'm gonna need more than a couple minutes to review it. I will try to look at this as soon as I get the time ...
Comment 4 Bem Jones-Bey 2013-08-26 16:12:37 PDT
(In reply to comment #3)
> Hm, I was hoping this would be a simple patch, but it isn't, and so I'm gonna need more than a couple minutes to review it. I will try to look at this as soon as I get the time ...

Unfortunately, I couldn't come up with a simple way to do it. Happy to wait until you have time, I'm not blocked on it.
Comment 5 Dirk Pranke 2013-09-18 16:42:22 PDT
Comment on attachment 209685 [details]
Patch

looks plausible. Sorry for the long delay.
Comment 6 WebKit Commit Bot 2013-09-18 17:54:43 PDT
Comment on attachment 209685 [details]
Patch

Clearing flags on attachment: 209685

Committed r156074: <http://trac.webkit.org/changeset/156074>
Comment 7 WebKit Commit Bot 2013-09-18 17:54:45 PDT
All reviewed patches have been landed.  Closing bug.