RESOLVED FIXED Bug 119159
W3C Test Import script reformats test HTML 
https://bugs.webkit.org/show_bug.cgi?id=119159
Summary W3C Test Import script reformats test HTML
Bem Jones-Bey
Reported 2013-07-26 14:03:00 PDT
When importing a W3C test, the import script reformats the HTML, which adds new lines and indentation. In some cases, this can break tests. The importer should not change the formatting of tests that it imports.
Attachments
Patch (21.02 KB, patch)
2013-08-26 15:55 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Bem Jones-Bey
Comment 1 2013-07-31 17:17:09 PDT
It looks like it may also break inline styles, so that should be tested for along with this fix,
Bem Jones-Bey
Comment 2 2013-08-26 15:55:01 PDT
Created attachment 209685 [details] Patch Rewrite test conversion to miminimize reformatting when rewriting tests.
Dirk Pranke
Comment 3 2013-08-26 16:07:11 PDT
Hm, I was hoping this would be a simple patch, but it isn't, and so I'm gonna need more than a couple minutes to review it. I will try to look at this as soon as I get the time ...
Bem Jones-Bey
Comment 4 2013-08-26 16:12:37 PDT
(In reply to comment #3) > Hm, I was hoping this would be a simple patch, but it isn't, and so I'm gonna need more than a couple minutes to review it. I will try to look at this as soon as I get the time ... Unfortunately, I couldn't come up with a simple way to do it. Happy to wait until you have time, I'm not blocked on it.
Dirk Pranke
Comment 5 2013-09-18 16:42:22 PDT
Comment on attachment 209685 [details] Patch looks plausible. Sorry for the long delay.
WebKit Commit Bot
Comment 6 2013-09-18 17:54:43 PDT
Comment on attachment 209685 [details] Patch Clearing flags on attachment: 209685 Committed r156074: <http://trac.webkit.org/changeset/156074>
WebKit Commit Bot
Comment 7 2013-09-18 17:54:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.