Bug 119152 - [mips] Fix LLINT build for mips backend
Summary: [mips] Fix LLINT build for mips backend
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 108664
  Show dependency tree / graph
 
Reported: 2013-07-26 09:43 PDT by Julien Brianceau
Modified: 2013-07-26 11:16 PDT (History)
8 users (show)

See Also:

Attachments
Fix range for riscLowerMalformedImmediates call in mips LLINT backend. (1.31 KB, patch)
2013-07-26 09:48 PDT, Julien Brianceau 		no flags Details | Formatted Diff | Diff
Fix arithmetic value ranges. (1.39 KB, patch)
2013-07-26 10:17 PDT, Balazs Kilvady 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-07-26 09:43:03 PDT 
Detected by mips build bot (http://build.webkit.org/builders/Qt%20Linux%20MIPS32R2%20LE%20Release/builds/16864):

offlineasm: Parsing /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter.asm and LLIntOffsetsExtractor and creating assembly file generated/LLIntAssembly.h.
offlineasm: Including file /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm
offlineasm: Including file /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm
/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/mips.rb:142:in `mipsOperand': Invalid immediate 65535 at /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:158At /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:1989 (RuntimeError)
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/mips.rb:621:in `emitMIPSCompact'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/mips.rb:692:in `lowerMIPS'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/backends.rb:67:in `lower'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/backends.rb:119:in `block in lower'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/backends.rb:117:in `each'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/backends.rb:117:in `lower'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:271:in `block (5 levels) in <main>'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:65:in `inAsm'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:270:in `block (4 levels) in <main>'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/settings.rb:182:in `emitCodeInConfiguration'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:269:in `block (3 levels) in <main>'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/settings.rb:89:in `forSettings'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:265:in `block (2 levels) in <main>'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:261:in `each'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:261:in `block in <main>'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:252:in `open'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:252:in `<main>'
make[2]: *** [generated/./LLIntAssembly.h] Error 1
Comment 1 Julien Brianceau 2013-07-26 09:48:02 PDT 
Created attachment 207536 [details]
Fix range for riscLowerMalformedImmediates call in mips LLINT backend.
Comment 2 Balazs Kilvady 2013-07-26 09:52:23 PDT 
(In reply to comment #1)
> Created an attachment (id=207536) [details]
> Fix range for riscLowerMalformedImmediates call in mips LLINT backend.

We have a better fix for this issue. I upload it soon.
Comment 3 Julien Brianceau 2013-07-26 09:56:45 PDT 
Comment on attachment 207536 [details]
Fix range for riscLowerMalformedImmediates call in mips LLINT backend.

Perfect :) I've chosen to submit the "safest" patch I found to fix the build (as I'm not a mips expert).

I'm waiting for your patch then, thanks!
Comment 4 Balazs Kilvady 2013-07-26 10:17:52 PDT 
Created attachment 207538 [details]
Fix arithmetic value ranges.
Comment 5 WebKit Commit Bot 2013-07-26 11:16:40 PDT 
Comment on attachment 207538 [details]
Fix arithmetic value ranges.

Clearing flags on attachment: 207538

Committed r153375: <http://trac.webkit.org/changeset/153375>
Comment 6 WebKit Commit Bot 2013-07-26 11:16:42 PDT 
All reviewed patches have been landed.  Closing bug.