Bug 119152 – [mips] Fix LLINT build for mips backend

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Julien Brianceau]

Detected by mips build bot (http://build.webkit.org/builders/Qt%20Linux%20MIPS32R2%20LE%20Release/builds/16864):

offlineasm: Parsing /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter.asm and LLIntOffsetsExtractor and creating assembly file generated/LLIntAssembly.h.
offlineasm: Including file /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm
offlineasm: Including file /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm
/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/mips.rb:142:in `mipsOperand': Invalid immediate 65535 at /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:158At /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:1989 (RuntimeError)
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/mips.rb:621:in `emitMIPSCompact'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/mips.rb:692:in `lowerMIPS'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/backends.rb:67:in `lower'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/backends.rb:119:in `block in lower'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/backends.rb:117:in `each'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/backends.rb:117:in `lower'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:271:in `block (5 levels) in <main>'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:65:in `inAsm'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:270:in `block (4 levels) in <main>'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/settings.rb:182:in `emitCodeInConfiguration'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:269:in `block (3 levels) in <main>'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/settings.rb:89:in `forSettings'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:265:in `block (2 levels) in <main>'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:261:in `each'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:261:in `block in <main>'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:252:in `open'
	from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:252:in `<main>'
make[2]: *** [generated/./LLIntAssembly.h] Error 1

[Julien Brianceau]

Created attachment 207536 [details]
Fix range for riscLowerMalformedImmediates call in mips LLINT backend.

[Balazs Kilvady]

(In reply to comment #1)
> Created an attachment (id=207536) [details]
> Fix range for riscLowerMalformedImmediates call in mips LLINT backend.

We have a better fix for this issue. I upload it soon.

[Julien Brianceau]

Comment on attachment 207536 [details]
Fix range for riscLowerMalformedImmediates call in mips LLINT backend.

Perfect :) I've chosen to submit the "safest" patch I found to fix the build (as I'm not a mips expert).

I'm waiting for your patch then, thanks!

[Balazs Kilvady]

Created attachment 207538 [details]
Fix arithmetic value ranges.

[WebKit Commit Bot]

Comment on attachment 207538 [details]
Fix arithmetic value ranges.

Clearing flags on attachment: 207538

Committed r153375: <http://trac.webkit.org/changeset/153375>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.