Bug 119134 - Merge viewport units/calcs conversion flags into fixed/percent flags
Summary: Merge viewport units/calcs conversion flags into fixed/percent flags
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-07-25 22:42 PDT by Ryosuke Niwa
Modified: 2013-07-25 22:42 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-07-25 22:42:02 PDT 
Perhaps we want to merge https://chromium.googlesource.com/chromium/blink/+/ef4c6bc20eb31ea1900f2dd5a8420cd9b4566ba4

In CSSPrimitiveValue::computeLength, we decide which conversions to
allow based on a template parameter which is a bitwise OR of several
flags. Since viewport units are a <length> type (as per css3 values),
we should be converting them whenever we can convert to a fixed length.
This patch removes the ViewportPercentageConversion flag and enables the
conversion whenever we enable a fixed length conversion.
Similarly, we should also convert calcs with both percentage and length
components (the CalculatedConversion flag) whenever both are allowed.