Bug 119132 - Fix Length blend() handling of Undefined lengths
Summary: Fix Length blend() handling of Undefined lengths
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-07-25 22:30 PDT by Ryosuke Niwa
Modified: 2022-09-14 21:27 PDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-07-25 22:30:11 PDT
Consider merging https://chromium.googlesource.com/chromium/blink/+/20468ab60e2454e3933b1542cc0852db8c43807c

Fixed transition behaviour when animating to/from 'none' keyword instead of hitting ASSERT failure.

     Length blend(const Length& from, double progress) const
     {
+        if (isUndefined() || from.isUndefined())
+            return *this;
+
Comment 1 Ahmad Saleem 2022-09-13 16:29:18 PDT
I took the test case from source.chromium.org of the one attached in the Chrome Commit and changed it into JSFiddle:

Link - https://jsfiddle.net/0x3butfq/show

All browsers (Safari Technology Preview 153, Firefox Nightly 106 and Chrome Canary 107) are showing following result:

Warning this test is running in real-time and may be flaky.
PASS - "max-width" property for "test" element at 0s saw something close to: none
PASS - "max-width" property for "test" element at 0.25s saw something close to: 10
PASS - "max-width" property for "test" element at 1s saw something close to: 10
PASS - "max-width" property for "test" element at 1.75s saw something close to: none
PASS - "max-width" property for "test" element at 2s saw something close to: none

____

Do we need this anymore or test? Thanks!