Bug 119103 – ANGLE needs Windows build system

• Status: RESOLVED
• Resolution: FIXED
• Component: ANGLE

[Alex Christensen]

The default ANGLE build system does not work well with WebKit.  It builds to the wrong place, it does not work with some of our changes, it does not run bison as a build step, etc.  There are enough changes to warrant replacing it with a separate build system, which we have already done for all other ports.

I've made projects and property sheets that work, but I have prevented all configurations from building it because it isn't used yet and because I don't want to break anything.

[Alex Christensen]

Created attachment 207482 [details]
Patch

[Brent Fulgham]

Comment on attachment 207482 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207482&action=review

r=me

> Source/ThirdParty/ANGLE/ANGLE.vcxproj/ANGLEGenerated.vcxproj:130
> +    <NMakePreprocessorDefinitions>WIN32;NDEBUG;</NMakePreprocessorDefinitions>

Stuff like this should be coming from the property sheets.  Visual Studio seeds this automatically, so it's probably just a matter of deleting the "local" override of the settings from the property sheet.

You can land as-is and we can clean up in a separate step.

[Alex Christensen]

r153346

[Alex Christensen]

(In reply to comment #2)
> > Source/ThirdParty/ANGLE/ANGLE.vcxproj/ANGLEGenerated.vcxproj:130
> > +    <NMakePreprocessorDefinitions>WIN32;NDEBUG;</NMakePreprocessorDefinitions>
> 
> Stuff like this should be coming from the property sheets.  Visual Studio seeds this automatically, so it's probably just a matter of deleting the "local" override of the settings from the property sheet.

I'll clean this up in the upcoming patch where I make angle actually generate files in this project and use the bison output.