NEW 119086
Grammar checking code is unnecessarily built for non-Mac ports 
https://bugs.webkit.org/show_bug.cgi?id=119086
Summary Grammar checking code is unnecessarily built for non-Mac ports
Grzegorz Czajkowski
Reported 2013-07-25 06:47:46 PDT
r151632 has shown that some parts of grammar checking code is built even if GRAMMAR_CHECKING macro is off. r151640 partially fixed it but still there is code that is not guarded by GRAMMAR_CHECKING macro. In consistency with other code, guard the feature where it's needed. Those changes have to be landed to commit https://bugs.webkit.org/show_bug.cgi?id=117585.
Attachments
proposed patch (34.08 KB, patch)
2013-07-25 06:54 PDT, Grzegorz Czajkowski 		buildbot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Grzegorz Czajkowski
Comment 1 2013-07-25 06:54:59 PDT
Created attachment 207455 [details] proposed patch
Ryosuke Niwa
Comment 2 2013-07-25 11:51:41 PDT
Comment on attachment 207455 [details] proposed patch I'm not sure if I like adding if-def everywhere like this. I'd prefer extracting various pieces into functions and stubbing them out in platforms where grammar checking is disabled.
Grzegorz Czajkowski
Comment 3 2013-07-25 12:09:03 PDT
(In reply to comment #2) > (From update of attachment 207455 [details]) > I'd prefer extracting various pieces into functions and stubbing them out in platforms where grammar checking is disabled. Sounds reasonable to me. I'll follow it. Thanks for your opinion.
Build Bot
Comment 4 2013-07-29 20:00:08 PDT
Comment on attachment 207455 [details] proposed patch Attachment 207455 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/1288231
Note You need to log in before you can comment on or make changes to this bug.