WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
119071
Add DRT test to ensure don't override z-index for overflow: scroll, -webkit-overflow-scrolling: touch
https://bugs.webkit.org/show_bug.cgi?id=119071
Summary
Add DRT test to ensure don't override z-index for overflow: scroll, -webkit-o...
Daniel Bates
Reported
2013-07-24 18:29:29 PDT
We should add a DRT test to ensure we don't regress the fix for
bug #119066
.
Attachments
Patch
(3.70 KB, patch)
2013-07-24 18:32 PDT
,
Daniel Bates
no flags
Details
Formatted Diff
Diff
Patch
(3.67 KB, patch)
2013-07-24 19:27 PDT
,
Daniel Bates
simon.fraser
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2013-07-24 18:32:29 PDT
Created
attachment 207426
[details]
Patch
Daniel Bates
Comment 2
2013-07-24 18:35:20 PDT
Comment on
attachment 207426
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=207426&action=review
> LayoutTests/compositing/overflow/should-not-override-z-index-for-element-with-non-auto-z-index-and-overflow-scroll-and-touch.html:32 > + testRunner.dumpAsText()
Will add missing semicolon to the end of this line before I land this patch.
Simon Fraser (smfr)
Comment 3
2013-07-24 19:00:14 PDT
Comment on
attachment 207426
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=207426&action=review
> LayoutTests/compositing/overflow/should-not-override-z-index-for-element-with-non-auto-z-index-and-overflow-scroll-and-touch.html:50 > + document.body.appendChild(document.createTextNode(document.elementFromPoint(10, 10).innerText)); > + document.body.removeChild(document.getElementById("test-container"));
This seems slightly convoluted. You could just do getElementFromPoint() and stuff "PASS" into a node if you hit the correct element. Or you could just make a ref test, since the visible ordering is also different.
Daniel Bates
Comment 4
2013-07-24 19:27:44 PDT
Created
attachment 207428
[details]
Patch
Daniel Bates
Comment 5
2013-07-24 19:31:22 PDT
Committed
r153111
: <
http://trac.webkit.org/changeset/153111
>
Daniel Bates
Comment 6
2013-07-24 19:31:55 PDT
<
rdar://problem/14541989
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug