Bug 119071 - Add DRT test to ensure don't override z-index for overflow: scroll, -webkit-overflow-scrolling: touch
Summary: Add DRT test to ensure don't override z-index for overflow: scroll, -webkit-o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-07-24 18:29 PDT by Daniel Bates
Modified: 2013-07-24 19:31 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.70 KB, patch)
2013-07-24 18:32 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (3.67 KB, patch)
2013-07-24 19:27 PDT, Daniel Bates 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2013-07-24 18:29:29 PDT 
We should add a DRT test to ensure we don't regress the fix for bug #119066.
Comment 1 Daniel Bates 2013-07-24 18:32:29 PDT 
Created attachment 207426 [details]
Patch
Comment 2 Daniel Bates 2013-07-24 18:35:20 PDT 
Comment on attachment 207426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207426&action=review

> LayoutTests/compositing/overflow/should-not-override-z-index-for-element-with-non-auto-z-index-and-overflow-scroll-and-touch.html:32
> +    testRunner.dumpAsText()

Will add missing semicolon to the end of this line before I land this patch.
Comment 3 Simon Fraser (smfr) 2013-07-24 19:00:14 PDT 
Comment on attachment 207426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207426&action=review

> LayoutTests/compositing/overflow/should-not-override-z-index-for-element-with-non-auto-z-index-and-overflow-scroll-and-touch.html:50
> +        document.body.appendChild(document.createTextNode(document.elementFromPoint(10, 10).innerText));
> +        document.body.removeChild(document.getElementById("test-container"));

This seems slightly convoluted. You could just do getElementFromPoint() and stuff "PASS" into a node if you hit the correct element.

Or you could just make a ref test, since the visible ordering is also different.
Comment 4 Daniel Bates 2013-07-24 19:27:44 PDT 
Created attachment 207428 [details]
Patch
Comment 5 Daniel Bates 2013-07-24 19:31:22 PDT 
Committed r153111: <http://trac.webkit.org/changeset/153111>
Comment 6 Daniel Bates 2013-07-24 19:31:55 PDT 
<rdar://problem/14541989>