Bug 119048 - Web Inspector: control+clicking on a numeric token should not show the context menu
Summary: Web Inspector: control+clicking on a numeric token should not show the contex...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-07-24 10:32 PDT by Antoine Quint
Modified: 2013-07-24 11:27 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.52 KB, patch)
2013-07-24 10:34 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2013-07-24 10:32:38 PDT
This is a followup bug to https://bugs.webkit.org/show_bug.cgi?id=118896 where we introduced the drag-to-adjust behaviour for numeric tokens and a mode where pressing down the control modifier key would change the increment to 0.1 / px. In the case where you'd start dragging with the control modifier key pressed, the context menu would appear, which is not what we should do since we're engaging in a dragging operation.
Comment 1 Radar WebKit Bug Importer 2013-07-24 10:33:20 PDT
<rdar://problem/14535098>
Comment 2 Antoine Quint 2013-07-24 10:34:03 PDT
Created attachment 207404 [details]
Patch
Comment 3 WebKit Commit Bot 2013-07-24 11:27:26 PDT
Comment on attachment 207404 [details]
Patch

Clearing flags on attachment: 207404

Committed r153091: <http://trac.webkit.org/changeset/153091>
Comment 4 WebKit Commit Bot 2013-07-24 11:27:28 PDT
All reviewed patches have been landed.  Closing bug.