Bug 119034 - [WK2] Move the implementation of WebEditorClient::checkTextOfParagraph to WebEditorClient.cpp
Summary: [WK2] Move the implementation of WebEditorClient::checkTextOfParagraph to Web...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kwang Yul Seo
URL:
Keywords:
Depends on:
Blocks: 118643
  Show dependency tree / graph
 
Reported: 2013-07-23 22:26 PDT by Kwang Yul Seo
Modified: 2013-07-30 10:39 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.15 KB, patch)
2013-07-23 22:28 PDT, Kwang Yul Seo 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2013-07-23 22:26:53 PDT 
The Mac and EFL ports use the same implementation of WebEditorClient::checkTextOfParagraph and GTK will use the same implementation too. So rather than duplicating the same code in platform specific files, move the implementation to platform agnostic WebProcess/WebCoreSupport/WebEditorClient.cpp.

See the comment in https://bugs.webkit.org/show_bug.cgi?id=118644#c5
Comment 1 Kwang Yul Seo 2013-07-23 22:28:51 PDT 
Created attachment 207373 [details]
Patch
Comment 2 Grzegorz Czajkowski 2013-07-23 23:57:07 PDT 
Thanks for taking it into consideration!

The spelling methods in WebEditorClient.cpp send the message to UIProcess. IMHO would be nice to keep checkTextOfParagraph in WebEditorClient.cpp to avoid code duplication in platform specific files (WebEditorClientMac.mm, WebEditorClientEfl.cpp, WebEditorClientGtk.cpp etc).

LGTM.
Comment 3 Kwang Yul Seo 2013-07-30 10:39:01 PDT 
Committed r153481: <http://trac.webkit.org/changeset/153481>