Bug 119021 - The offsetLeft of rows should include border-spacing
Summary: The offsetLeft of rows should include border-spacing
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robert Hogan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-23 14:06 PDT by Robert Hogan
Modified: 2023-05-08 07:08 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2013-07-23 14:06:09 PDT 
...
Comment 1 Robert Hogan 2013-07-23 14:07:13 PDT 
RenderTableSection.cpp:

 527     for (unsigned r = 0; r < totalRows; r++) {
 528         // Set the row's x/y position and width/height.
 529         if (RenderTableRow* rowRenderer = m_grid[r].rowRenderer) {
 530             // FIXME: the x() position of the row should be table()->hBorderSpacing() so that it can 
 531             // report the correct offsetLeft. However, that will require a lot of rebaselining of test results.
 532             rowRenderer->setLocation(LayoutPoint(0, m_rowPos[r]));
Comment 2 Ahmad Saleem 2023-05-08 07:08:44 PDT 
(In reply to Robert Hogan from comment #1)
> RenderTableSection.cpp:
> 
>  527     for (unsigned r = 0; r < totalRows; r++) {
>  528         // Set the row's x/y position and width/height.
>  529         if (RenderTableRow* rowRenderer = m_grid[r].rowRenderer) {
>  530             // FIXME: the x() position of the row should be
> table()->hBorderSpacing() so that it can 
>  531             // report the correct offsetLeft. However, that will
> require a lot of rebaselining of test results.
>  532             rowRenderer->setLocation(LayoutPoint(0, m_rowPos[r]));

We still have this:

https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderTableSection.cpp#559