Bug 119018 – [CoordnatedGraphics] WKViewFindZoomableAreaForRect() needs an API test.

• Status: NEW
• Component: WebKit EFL

[Marcelo Lira]

It sure does.

[Marcelo Lira]

Created attachment 207345 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 207345 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207345&action=review

> Tools/ChangeLog:3
> +        [EFL][WK2] WKViewFindZoomableAreaForRect() needs an API test.

It seems to me that this patch isn't only for WK2 EFL port. I think [EFL] can be changed with [CoordnatedGraphics].

> Tools/ChangeLog:7
> +

Missing patch description.

[Chris Dumez]

Comment on attachment 207345 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207345&action=review

> Tools/TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewFindZoomableAreaForRect.cpp:97
> +    EXPECT_EQ(lastArea.origin.x, 0);

Your conditions are reversed. The expected value should be on the left.

[Marcelo Lira]

Created attachment 207395 [details]
Patch

[Chris Dumez]

Comment on attachment 207395 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207395&action=review

> Tools/ChangeLog:3
> +        [CoordnatedGraphics][WK2] WKViewFindZoomableAreaForRect() needs an API test.

[CoordinatedGraphics]

> Tools/TestWebKitAPI/PlatformEfl.cmake:104
> +    CoordinatedGraphics/WKViewFindZoomableAreaForRect

Would be nice if you could add the test to Qt as well maybe.

> Tools/TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewFindZoomableAreaForRect.cpp:63
> +    WKRetainPtr<WKContextRef> context(AdoptWK, WKContextCreate());

I was told we prefer to use context = adoptWK(WKContextCreate()); although equivalent.

> Tools/TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewFindZoomableAreaForRect.cpp:64
> +    WKRetainPtr<WKViewRef> webView(AdoptWK, WKViewCreate(context.get(), 0));

Ditto.

> Tools/TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewFindZoomableAreaForRect.cpp:84
> +    WKRetainPtr<WKURLRef> url(AdoptWK, Util::createURLForResource("CoordinatedGraphics/red-and-green-rectangles", "html"));

Ditto.

> Tools/TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewFindZoomableAreaForRect.cpp:97
> +    EXPECT_EQ(lastArea.origin.x, 0);

Conditions are reversed.

[Marcelo Lira]

Created attachment 207397 [details]
Patch

[Marcelo Lira]

Comment on attachment 207395 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207395&action=review

>> Tools/TestWebKitAPI/PlatformEfl.cmake:104
>> +    CoordinatedGraphics/WKViewFindZoomableAreaForRect
> 
> Would be nice if you could add the test to Qt as well maybe.

I know, but Qt is not my turf right now. :\

[Brady Eidson]

Comment on attachment 207397 [details]
Patch

Assuming that patches for review since 2013 are stale, r-