Bug 119018 - [CoordnatedGraphics] WKViewFindZoomableAreaForRect() needs an API test.
Summary: [CoordnatedGraphics] WKViewFindZoomableAreaForRect() needs an API test.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Marcelo Lira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-23 13:27 PDT by Marcelo Lira
Modified: 2016-05-24 22:02 PDT (History)
8 users (show)

See Also:

Attachments
Patch (8.24 KB, patch)
2013-07-23 13:31 PDT, Marcelo Lira 		no flags Details | Formatted Diff | Diff
Patch (8.32 KB, patch)
2013-07-24 08:17 PDT, Marcelo Lira 		no flags Details | Formatted Diff | Diff
Patch (8.32 KB, patch)
2013-07-24 08:58 PDT, Marcelo Lira 		beidson: review-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcelo Lira 2013-07-23 13:27:29 PDT 
It sure does.
Comment 1 Marcelo Lira 2013-07-23 13:31:35 PDT 
Created attachment 207345 [details]
Patch
Comment 2 Gyuyoung Kim 2013-07-23 18:38:12 PDT 
Comment on attachment 207345 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207345&action=review

> Tools/ChangeLog:3
> +        [EFL][WK2] WKViewFindZoomableAreaForRect() needs an API test.

It seems to me that this patch isn't only for WK2 EFL port. I think [EFL] can be changed with [CoordnatedGraphics].

> Tools/ChangeLog:7
> +

Missing patch description.
Comment 3 Chris Dumez 2013-07-24 08:16:02 PDT 
Comment on attachment 207345 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207345&action=review

> Tools/TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewFindZoomableAreaForRect.cpp:97
> +    EXPECT_EQ(lastArea.origin.x, 0);

Your conditions are reversed. The expected value should be on the left.
Comment 4 Marcelo Lira 2013-07-24 08:17:12 PDT 
Created attachment 207395 [details]
Patch
Comment 5 Chris Dumez 2013-07-24 08:22:23 PDT 
Comment on attachment 207395 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207395&action=review

> Tools/ChangeLog:3
> +        [CoordnatedGraphics][WK2] WKViewFindZoomableAreaForRect() needs an API test.

[CoordinatedGraphics]

> Tools/TestWebKitAPI/PlatformEfl.cmake:104
> +    CoordinatedGraphics/WKViewFindZoomableAreaForRect

Would be nice if you could add the test to Qt as well maybe.

> Tools/TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewFindZoomableAreaForRect.cpp:63
> +    WKRetainPtr<WKContextRef> context(AdoptWK, WKContextCreate());

I was told we prefer to use context = adoptWK(WKContextCreate()); although equivalent.

> Tools/TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewFindZoomableAreaForRect.cpp:64
> +    WKRetainPtr<WKViewRef> webView(AdoptWK, WKViewCreate(context.get(), 0));

Ditto.

> Tools/TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewFindZoomableAreaForRect.cpp:84
> +    WKRetainPtr<WKURLRef> url(AdoptWK, Util::createURLForResource("CoordinatedGraphics/red-and-green-rectangles", "html"));

Ditto.

> Tools/TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewFindZoomableAreaForRect.cpp:97
> +    EXPECT_EQ(lastArea.origin.x, 0);

Conditions are reversed.
Comment 6 Marcelo Lira 2013-07-24 08:58:00 PDT 
Created attachment 207397 [details]
Patch
Comment 7 Marcelo Lira 2013-07-24 09:01:07 PDT 
Comment on attachment 207395 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207395&action=review

>> Tools/TestWebKitAPI/PlatformEfl.cmake:104
>> +    CoordinatedGraphics/WKViewFindZoomableAreaForRect
> 
> Would be nice if you could add the test to Qt as well maybe.

I know, but Qt is not my turf right now. :\
Comment 8 Brady Eidson 2016-05-24 22:02:00 PDT 
Comment on attachment 207397 [details]
Patch

Assuming that patches for review since 2013 are stale, r-