Bug 119007 - Add a test for plug-in unavailability indicator obscurity detection
Summary: Add a test for plug-in unavailability indicator obscurity detection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-23 02:14 PDT by Tim Horton
Modified: 2013-07-31 12:27 PDT (History)
5 users (show)

See Also:

Attachments
patch (22.54 KB, patch)
2013-07-23 02:17 PDT, Tim Horton 		gtk-ews: commit-queue-
Details | Formatted Diff | Diff
fix gtk in theory (23.68 KB, patch)
2013-07-23 10:05 PDT, Tim Horton 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-07-23 02:14:19 PDT 
Since we don't have any, I'm going to cover lots of cases in one big test.
Comment 1 Tim Horton 2013-07-23 02:17:30 PDT 
Created attachment 207315 [details]
patch
Comment 2 Tim Horton 2013-07-23 02:19:45 PDT 
Comment on attachment 207315 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207315&action=review

> LayoutTests/plugins/unavailable-plugin-indicator-obscurity.html:121
> +        <div class="container">
> +            <embed id="pointerEventsBlockedOnObscuringSibling" class="shouldNotBeObscured" type="application/x-webkit-test-netscape"></embed>
> +            <div class="cover" style="pointer-events: none;"></div>
> +        </div>

I think the fact that this one passes is a bug (you can't see the plugin because it's covered up, but we think it's not covered because the thing that's covering it has pointer-events: none set on it). But I'll leave that for Gordon to decide and file a separate bug about...
Comment 3 kov's GTK+ EWS bot 2013-07-23 02:22:57 PDT 
Comment on attachment 207315 [details]
patch

Attachment 207315 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1109099
Comment 4 Tim Horton 2013-07-23 02:31:51 PDT 
(In reply to comment #3)
> (From update of attachment 207315 [details])
> Attachment 207315 [details] did not pass gtk-ews (gtk):
> Output: http://webkit-queues.appspot.com/results/1109099

I dunno what that's about, and the fact that the gtk-wk2 bot is happy makes me even more confused.
Comment 5 Tim Horton 2013-07-23 10:05:44 PDT 
Created attachment 207337 [details]
fix gtk in theory
Comment 6 Tim Horton 2013-07-23 10:13:51 PDT 
http://trac.webkit.org/changeset/153054
Comment 7 Tim Horton 2013-07-31 12:27:35 PDT 
(In reply to comment #2)
> (From update of attachment 207315 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207315&action=review
> 
> > LayoutTests/plugins/unavailable-plugin-indicator-obscurity.html:121
> > +        <div class="container">
> > +            <embed id="pointerEventsBlockedOnObscuringSibling" class="shouldNotBeObscured" type="application/x-webkit-test-netscape"></embed>
> > +            <div class="cover" style="pointer-events: none;"></div>
> > +        </div>
> 
> I think the fact that this one passes is a bug (you can't see the plugin because it's covered up, but we think it's not covered because the thing that's covering it has pointer-events: none set on it). But I'll leave that for Gordon to decide and file a separate bug about...

I filed https://bugs.webkit.org/show_bug.cgi?id=119348 about this, and changed the test to fail that test case.