Bug 119007 – Add a test for plug-in unavailability indicator obscurity detection

• Status: RESOLVED
• Resolution: FIXED
• Component: Plug-ins

[Tim Horton]

Since we don't have any, I'm going to cover lots of cases in one big test.

[Tim Horton]

Created attachment 207315 [details]
patch

[Tim Horton]

Comment on attachment 207315 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207315&action=review

> LayoutTests/plugins/unavailable-plugin-indicator-obscurity.html:121
> +        <div class="container">
> +            <embed id="pointerEventsBlockedOnObscuringSibling" class="shouldNotBeObscured" type="application/x-webkit-test-netscape"></embed>
> +            <div class="cover" style="pointer-events: none;"></div>
> +        </div>

I think the fact that this one passes is a bug (you can't see the plugin because it's covered up, but we think it's not covered because the thing that's covering it has pointer-events: none set on it). But I'll leave that for Gordon to decide and file a separate bug about...

[kov's GTK+ EWS bot]

Comment on attachment 207315 [details]
patch

Attachment 207315 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1109099

[Tim Horton]

(In reply to comment #3)
> (From update of attachment 207315 [details])
> Attachment 207315 [details] did not pass gtk-ews (gtk):
> Output: http://webkit-queues.appspot.com/results/1109099

I dunno what that's about, and the fact that the gtk-wk2 bot is happy makes me even more confused.

[Tim Horton]

Created attachment 207337 [details]
fix gtk in theory

[Tim Horton]

http://trac.webkit.org/changeset/153054

[Tim Horton]

(In reply to comment #2)
> (From update of attachment 207315 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207315&action=review
> 
> > LayoutTests/plugins/unavailable-plugin-indicator-obscurity.html:121
> > +        <div class="container">
> > +            <embed id="pointerEventsBlockedOnObscuringSibling" class="shouldNotBeObscured" type="application/x-webkit-test-netscape"></embed>
> > +            <div class="cover" style="pointer-events: none;"></div>
> > +        </div>
> 
> I think the fact that this one passes is a bug (you can't see the plugin because it's covered up, but we think it's not covered because the thing that's covering it has pointer-events: none set on it). But I'll leave that for Gordon to decide and file a separate bug about...

I filed https://bugs.webkit.org/show_bug.cgi?id=119348 about this, and changed the test to fail that test case.