Bug 118997 - Need ExpressionRangeInfo before ResolveForPuts in strict mode
Summary: Need ExpressionRangeInfo before ResolveForPuts in strict mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-22 17:36 PDT by Mark Lam
Modified: 2013-07-23 18:10 PDT (History)
3 users (show)

See Also:

Attachments
the patch (2.48 KB, patch)
2013-07-22 17:53 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2013-07-22 17:36:45 PDT 
If we add an assertion in UnlinkedCodeBlock::expressionRangeForBytecodeOffset() to ensure that we are able to find an ExpressionRangeInfo for any given bytecode, the following tests will fail:
    fast/js/basic-strict-mode.html
    fast/js/mozilla/strict/8.7.2.html

We should emit expression info before calls to emitResolveBaseForPut() if we're in strict mode.
Comment 1 Mark Lam 2013-07-22 17:53:54 PDT 
Created attachment 207299 [details]
the patch

This patch was already previously r+ by Oliver as part of a patch in https://bugs.webkit.org/show_bug.cgi?id=116853.  Uploading it here as a stand alone patch so that it can be landed separately from the BinaryOpNode change in the original bug.
Comment 2 Mark Lam 2013-07-23 18:09:36 PDT 
Landed in r153074: <http://trac.webkit.org/changeset/153074>.
Comment 3 Mark Lam 2013-07-23 18:10:37 PDT 
Comment on attachment 207299 [details]
the patch

This patch was already previously reviewed by Oliver.  So, I've landed it, and canceling the review.