Bug 118993 - Dictionary hotkey does not work on vertical text
Summary: Dictionary hotkey does not work on vertical text
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-07-22 15:53 PDT by Alexey Proskuryakov
Modified: 2013-07-23 12:08 PDT (History)
0 users

See Also:

Attachments
test case (1.79 KB, text/html)
2013-07-22 15:53 PDT, Alexey Proskuryakov 		no flags Details
proposed fix (13.07 KB, patch)
2013-07-23 11:20 PDT, Alexey Proskuryakov 		enrica: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-07-22 15:53:56 PDT 
Created attachment 207287 [details]
test case

Steps to reproduce:

1) Open attached test case.
2) Position the mouse pointer over some vertical text at the right hand side of the definition.
3) Three-finger tap the trackpad or press Command-Control-D

EXPECTED:
The text under the mouse pointer is highlighted and the Lookup popover appears

ACTUAL:
Nothing happens. Lookup fails silently.

<rdar://problem/14478260>
Comment 1 Alexey Proskuryakov 2013-07-23 11:20:42 PDT 
Created attachment 207340 [details]
proposed fix
Comment 2 Enrica Casucci 2013-07-23 11:45:36 PDT 
Comment on attachment 207340 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=207340&action=review

> Source/WebCore/editing/Editor.cpp:2694
> +    bool startCaretIsVertical = startCaretRect.width() == caretWidth;

I think it would be more clear if you named this variable to indicate the direction of the text rather than the caret. Here caret is vertical mean text is horizontal and that confused me.
Comment 3 Alexey Proskuryakov 2013-07-23 12:08:35 PDT 
Committed <http://trac.webkit.org/r153060>.