RESOLVED FIXED 118981
Clean up DragImage 
https://bugs.webkit.org/show_bug.cgi?id=118981
Summary Clean up DragImage
Zan Dobersek
Reported 2013-07-22 13:30:51 PDT
Clean up DragImage
Attachments
Patch (1.69 KB, patch)
2013-07-22 13:32 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (2.86 KB, patch)
2013-07-29 04:48 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-07-22 13:32:13 PDT
Created attachment 207269 [details] Patch
EFL EWS Bot
Comment 2 2013-07-22 13:36:40 PDT
Comment on attachment 207269 [details] Patch Attachment 207269 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1166125
Early Warning System Bot
Comment 3 2013-07-22 13:38:26 PDT
Comment on attachment 207269 [details] Patch Attachment 207269 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1094399
Early Warning System Bot
Comment 4 2013-07-22 13:38:38 PDT
Comment on attachment 207269 [details] Patch Attachment 207269 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1137424
kov's GTK+ EWS bot
Comment 5 2013-07-22 13:39:03 PDT
Comment on attachment 207269 [details] Patch Attachment 207269 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1092375
EFL EWS Bot
Comment 6 2013-07-22 13:40:42 PDT
Comment on attachment 207269 [details] Patch Attachment 207269 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1082629
Build Bot
Comment 7 2013-07-22 13:52:34 PDT
Comment on attachment 207269 [details] Patch Attachment 207269 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1135406
Build Bot
Comment 8 2013-07-22 14:08:45 PDT
Comment on attachment 207269 [details] Patch Attachment 207269 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1153128
Darin Adler
Comment 9 2013-07-22 16:41:56 PDT
Comment on attachment 207269 [details] Patch Looks like Frame.h gets its forward declaration of Range from this header.
Zan Dobersek
Comment 10 2013-07-23 05:20:20 PDT
The Clipboard header does as well. Both have the forward declaration added in bug #118985. The forward declaration is basically moved into headers where it's actually in use, unlike in the DragImage header.
Zan Dobersek
Comment 11 2013-07-29 04:48:42 PDT
Created attachment 207642 [details] Patch
Zan Dobersek
Comment 12 2013-07-29 07:36:23 PDT
Comment on attachment 207642 [details] Patch Clearing flags on attachment: 207642 Committed r153424: <http://trac.webkit.org/changeset/153424>
Zan Dobersek
Comment 13 2013-07-29 07:36:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.