Bug 118981 - Clean up DragImage
Summary: Clean up DragImage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on: 118985
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-22 13:30 PDT by Zan Dobersek
Modified: 2013-07-29 07:36 PDT (History)
12 users (show)

See Also:


Attachments
Patch (1.69 KB, patch)
2013-07-22 13:32 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch (2.86 KB, patch)
2013-07-29 04:48 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-07-22 13:30:51 PDT
Clean up DragImage
Comment 1 Zan Dobersek 2013-07-22 13:32:13 PDT
Created attachment 207269 [details]
Patch
Comment 2 EFL EWS Bot 2013-07-22 13:36:40 PDT
Comment on attachment 207269 [details]
Patch

Attachment 207269 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1166125
Comment 3 Early Warning System Bot 2013-07-22 13:38:26 PDT
Comment on attachment 207269 [details]
Patch

Attachment 207269 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1094399
Comment 4 Early Warning System Bot 2013-07-22 13:38:38 PDT
Comment on attachment 207269 [details]
Patch

Attachment 207269 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1137424
Comment 5 kov's GTK+ EWS bot 2013-07-22 13:39:03 PDT
Comment on attachment 207269 [details]
Patch

Attachment 207269 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1092375
Comment 6 EFL EWS Bot 2013-07-22 13:40:42 PDT
Comment on attachment 207269 [details]
Patch

Attachment 207269 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1082629
Comment 7 Build Bot 2013-07-22 13:52:34 PDT
Comment on attachment 207269 [details]
Patch

Attachment 207269 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1135406
Comment 8 Build Bot 2013-07-22 14:08:45 PDT
Comment on attachment 207269 [details]
Patch

Attachment 207269 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1153128
Comment 9 Darin Adler 2013-07-22 16:41:56 PDT
Comment on attachment 207269 [details]
Patch

Looks like Frame.h gets its forward declaration of Range from this header.
Comment 10 Zan Dobersek 2013-07-23 05:20:20 PDT
The Clipboard header does as well. Both have the forward declaration added in bug #118985.

The forward declaration is basically moved into headers where it's actually in use, unlike in the DragImage header.
Comment 11 Zan Dobersek 2013-07-29 04:48:42 PDT
Created attachment 207642 [details]
Patch
Comment 12 Zan Dobersek 2013-07-29 07:36:23 PDT
Comment on attachment 207642 [details]
Patch

Clearing flags on attachment: 207642

Committed r153424: <http://trac.webkit.org/changeset/153424>
Comment 13 Zan Dobersek 2013-07-29 07:36:29 PDT
All reviewed patches have been landed.  Closing bug.