Bug 118980 - [GTK] Mock GDK_IS_X11_DISPLAY macro can be redefined unnecessarily
Summary: [GTK] Mock GDK_IS_X11_DISPLAY macro can be redefined unnecessarily
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on: 117895
Blocks:
  Show dependency tree / graph
 
Reported: 2013-07-22 13:23 PDT by Zan Dobersek
Modified: 2013-07-23 02:50 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.22 KB, patch)
2013-07-22 13:26 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-07-22 13:23:43 PDT 
[GTK] Mock GDK_IS_X11_DISPLAY macro can be redefined unnecessarily
Comment 1 Zan Dobersek 2013-07-22 13:26:36 PDT 
Created attachment 207268 [details]
Patch
Comment 2 Carlos Garcia Campos 2013-07-22 23:04:37 PDT 
Comment on attachment 207268 [details]
Patch

This is what I did in the stable branch, although I didn't reuse the previous #ifdef block. LGTM too, thanks for fixing it.
Comment 3 Zan Dobersek 2013-07-23 02:47:09 PDT 
(In reply to comment #2)
> (From update of attachment 207268 [details])
> This is what I did in the stable branch, although I didn't reuse the previous #ifdef block. LGTM too, thanks for fixing it.

Didn't spot that patch. Would have used it otherwise.
Comment 4 Zan Dobersek 2013-07-23 02:48:24 PDT 
Comment on attachment 207268 [details]
Patch

Clearing flags on attachment: 207268

Committed r153035: <http://trac.webkit.org/changeset/153035>
Comment 5 Zan Dobersek 2013-07-23 02:48:31 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Carlos Garcia Campos 2013-07-23 02:50:26 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 207268 [details] [details])
> > This is what I did in the stable branch, although I didn't reuse the previous #ifdef block. LGTM too, thanks for fixing it.
> 
> Didn't spot that patch. Would have used it otherwise.

I actually fixed it directly when merging the original commit. I prefer your patch that reuses the ifdef block, so no problem.