Bug 118971 - [Old Web Inspector] When right-clicking on a DataGrid column, show editing menu option as "Edit <columnName>" instead of just "Edit"
Summary: [Old Web Inspector] When right-clicking on a DataGrid column, show editing me...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-22 07:53 PDT by Diego Pino
Modified: 2013-07-22 11:47 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.27 KB, patch)
2013-07-22 09:34 PDT, Diego Pino 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2013-07-22 07:53:01 PDT 
Right click on a data column in a Grid shows up a context menu for Adding a new value, delete the current one or edit it. There's a FIXME comment suggesting to add the name of the column to be edited, for instance, "Edit 'Key'" instead of just simply "Edit", as it may be more clear what it does.
Comment 1 Diego Pino 2013-07-22 09:34:49 PDT 
Created attachment 207253 [details]
Patch
Comment 2 Diego Pino 2013-07-22 09:43:50 PDT 
I added the literal "Edit “%s”" directly to Source/WebCore/English.lproj/localizedStrings.js. I don't know if there's any tool to do that automatically. Apparently update-webkit-localizable-strings only works with the new web inspector.
Comment 3 WebKit Commit Bot 2013-07-22 11:47:05 PDT 
Comment on attachment 207253 [details]
Patch

Clearing flags on attachment: 207253

Committed r152985: <http://trac.webkit.org/changeset/152985>
Comment 4 WebKit Commit Bot 2013-07-22 11:47:06 PDT 
All reviewed patches have been landed.  Closing bug.