Bug 118970 – [Web Inspector] When right-clicking on a DataGrid column, show editing menu option as "Edit <columnName>" instead of just "Edit"

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Diego Pino]

Right click on a data column in a Grid shows up a context menu for Adding a new value, delete the current one or edit it. There's a FIXME comment suggesting to add the name of the column to be edited, for instance, "Edit 'Key'" instead of just simply "Edit", as it may be more clear what it does.

[Radar WebKit Bug Importer]

<rdar://problem/14509359>

[Diego Pino]

Created attachment 207247 [details]
Patch

[Antoine Quint]

Comment on attachment 207247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207247&action=review

> Source/WebInspectorUI/UserInterface/DataGrid.js:1111
> +        function getColumnIdentifier(node) {
> +            var element = node.enclosingNodeOrSelfWithNodeName("td");
> +            return parseInt(element.className.match(/\b(\d+)-column\b/)[1], 10);
> +        }

I think it's a little overkill to add this inline function which is only used once.

[Timothy Hatcher]

Comment on attachment 207247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207247&action=review

> Source/WebInspectorUI/ChangeLog:9
> +        * Localizations/en.lproj/localizedStrings.js: Add literal "Edit '%s'"

If you didn't, you should use the update-webkit-localized-strings script, which will update this file for you.

> Source/WebInspectorUI/UserInterface/DataGrid.js:1128
> +                    contextMenu.appendItem(WebInspector.UIString("Edit '%s'").format(columnTitle), this._startEditing.bind(this, event.target));

This should use double curly quotes (“”) and not single quotes.

[Diego Pino]

Created attachment 207251 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 207251 [details]
Patch

Clearing flags on attachment: 207251

Committed r152979: <http://trac.webkit.org/changeset/152979>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.