RESOLVED FIXED 118959
Web Inspector: Cleanup InspectorFrontendHostStub.js 
https://bugs.webkit.org/show_bug.cgi?id=118959
Summary Web Inspector: Cleanup InspectorFrontendHostStub.js
Seokju Kwon
Reported 2013-07-21 17:13:44 PDT
Remove some function because we dont use on New Inspector.
Attachments
Patch (3.33 KB, patch)
2013-07-21 17:16 PDT, Seokju Kwon 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-07-21 17:13:53 PDT
<rdar://problem/14505580>
Seokju Kwon
Comment 2 2013-07-21 17:16:17 PDT
Created attachment 207221 [details] Patch
Timothy Hatcher
Comment 3 2013-07-21 20:00:59 PDT
Comment on attachment 207221 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207221&action=review > Source/WebInspectorUI/UserInterface/InspectorFrontendHostStub.js:-125 > - if (this._fileBuffers[url]) > - throw new Error("Concurrent file modification denied."); > - > - this._fileBuffers[url] = [content]; > - }, We do use save, which you kept. I agree, this implementation does nothing unless close is also called. So it is weird.
WebKit Commit Bot
Comment 4 2013-07-21 20:23:07 PDT
Comment on attachment 207221 [details] Patch Clearing flags on attachment: 207221 Committed r152956: <http://trac.webkit.org/changeset/152956>
WebKit Commit Bot
Comment 5 2013-07-21 20:23:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.