Bug 118953 - Java Updater not launched on Lion and Mountain Lion
Summary: Java Updater not launched on Lion and Mountain Lion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-21 11:47 PDT by Anders Carlsson
Modified: 2013-07-21 11:54 PDT (History)
0 users

See Also:

Attachments
Patch (2.25 KB, patch)
2013-07-21 11:49 PDT, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-07-21 11:47:48 PDT 
Java Updater not launched on Lion and Mountain Lion
Comment 1 Anders Carlsson 2013-07-21 11:49:04 PDT 
Created attachment 207210 [details]
Patch
Comment 2 Sam Weinig 2013-07-21 11:50:46 PDT 
Comment on attachment 207210 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207210&action=review

> Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm:413
> +    NSURL *url = [NSURL URLWithString:urlString];
> +    if (![url isFileURL])
> +        return false;
>  
> -    return [[NSURL URLWithString:urlString] isEqual:javaUpdaterURL];
> +    NSString *javaUpdaterPath = [NSString pathWithComponents:[NSArray arrayWithObjects:(NSString *)pluginProcessAttributes.moduleInfo.path, @"Contents/Resources/Java Updater.app", nil]];
> +    return [url.path isEqualToString:javaUpdaterPath];

This could either use a comment.
Comment 3 Anders Carlsson 2013-07-21 11:54:26 PDT 
Committed r152950: <http://trac.webkit.org/changeset/152950>