Bug 118936 – The computed values of fix length padding should be subpixel precision like margin

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Ryosuke Niwa]

Extract a function to compute the zoom adjust values for paddings and margings

[Ryosuke Niwa]

Created attachment 207183 [details]
Cleanup

[Build Bot]

Comment on attachment 207183 [details]
Cleanup

Attachment 207183 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1137091

New failing tests:
fast/shapes/shape-inside/shape-inside-shape-logical-top.html

[Build Bot]

Created attachment 207191 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3

[Build Bot]

Comment on attachment 207183 [details]
Cleanup

Attachment 207183 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1133173

New failing tests:
fast/shapes/shape-inside/shape-inside-shape-logical-top.html

[Build Bot]

Created attachment 207194 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Benjamin Poulain]

Comment on attachment 207183 [details]
Cleanup

I like it!

[Ryosuke Niwa]

Actually, there is a slight behavior difference in that computed style's puddings wil now return sun pixel values instead of whole values since we no longer goes through the render tree. I don't think that's a significant change since new behavior matches that of margins but we do have to "fix" the failing test.

[Benjamin Poulain]

Comment on attachment 207183 [details]
Cleanup

Oh, I thought that only a refactoring!
Back to review.

[Ryosuke Niwa]

Created attachment 207262 [details]
Fixed the test

[Simon Fraser (smfr)]

Comment on attachment 207262 [details]
Fixed the test

View in context: https://bugs.webkit.org/attachment.cgi?id=207262&action=review

> Source/WebCore/ChangeLog:10
> +        Extract a function to compute the zoom adjust values for paddings and margings
> +        https://bugs.webkit.org/show_bug.cgi?id=118936
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Extracted zoomAdjustedPaddingOrMarginPixelValue and used it to compute
> +        the zoom adjust values for margings and paddings to reduce the code duplication.
> +

This needs to make it clear that there's a behavior change.

[Ryosuke Niwa]

Created attachment 207273 [details]
Updated the change log

[Ryosuke Niwa]

Created attachment 207297 [details]
Fixes the bug

[Simon Fraser (smfr)]

Comment on attachment 207297 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=207297&action=review

> Source/WebCore/ChangeLog:9
> +        for paddings. Fixed the bug by returning the computed value when they're of fixed length.

paddings -> padding

[Ryosuke Niwa]

Committed r153067: <http://trac.webkit.org/changeset/153067>