Bug 118932 - WinCairo build configuration errors
Summary: WinCairo build configuration errors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-19 18:55 PDT by Alex Christensen
Modified: 2013-07-22 11:13 PDT (History)
2 users (show)

See Also:

Attachments
Patch (22.75 KB, patch)
2013-07-19 18:56 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-07-19 18:55:25 PDT 
After r152921, the 64-bit WinCairo was set to build QTMovieWin (which it should not).  Also, WinCairo fails to build AssembleBuildLogs because of the name of folders, but it isn't really necessary to run this project, is it?  Also, for some reason the Debug_WinCairo configuration is set to build with the DebugSuffix configuration.  Why do we even have that configuration any more?
Comment 1 Alex Christensen 2013-07-19 18:56:17 PDT 
Created attachment 207166 [details]
Patch
Comment 2 Brent Fulgham 2013-07-22 10:51:11 PDT 
Comment on attachment 207166 [details]
Patch

r=me.  Note that DebugSuffix is important to keep around, but you are right that the existing 64-bit configurations for WinCairo were improperly referencing it.
Comment 3 WebKit Commit Bot 2013-07-22 11:13:32 PDT 
Comment on attachment 207166 [details]
Patch

Clearing flags on attachment: 207166

Committed r152983: <http://trac.webkit.org/changeset/152983>
Comment 4 WebKit Commit Bot 2013-07-22 11:13:34 PDT 
All reviewed patches have been landed.  Closing bug.