WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
118932
WinCairo build configuration errors
https://bugs.webkit.org/show_bug.cgi?id=118932
Summary
WinCairo build configuration errors
Alex Christensen
Reported
2013-07-19 18:55:25 PDT
After
r152921
, the 64-bit WinCairo was set to build QTMovieWin (which it should not). Also, WinCairo fails to build AssembleBuildLogs because of the name of folders, but it isn't really necessary to run this project, is it? Also, for some reason the Debug_WinCairo configuration is set to build with the DebugSuffix configuration. Why do we even have that configuration any more?
Attachments
Patch
(22.75 KB, patch)
2013-07-19 18:56 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2013-07-19 18:56:17 PDT
Created
attachment 207166
[details]
Patch
Brent Fulgham
Comment 2
2013-07-22 10:51:11 PDT
Comment on
attachment 207166
[details]
Patch r=me. Note that DebugSuffix is important to keep around, but you are right that the existing 64-bit configurations for WinCairo were improperly referencing it.
WebKit Commit Bot
Comment 3
2013-07-22 11:13:32 PDT
Comment on
attachment 207166
[details]
Patch Clearing flags on attachment: 207166 Committed
r152983
: <
http://trac.webkit.org/changeset/152983
>
WebKit Commit Bot
Comment 4
2013-07-22 11:13:34 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug