Bug 118931 - Windows 64 bit assembly files should be included
Summary: Windows 64 bit assembly files should be included
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P4 Minor
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-07-19 18:17 PDT by Alex Christensen
Modified: 2013-11-18 17:26 PST (History)
4 users (show)

See Also:


Attachments
Patch (6.19 KB, patch)
2013-07-19 18:26 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (892.89 KB, application/zip)
2013-07-19 21:34 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-07-19 18:17:12 PDT
The Windows 64-bit build has two assembly files that need to be included in the build: JavaScriptCore/jit/JITStubsMSVC64.asm and WebCore/plugins/win/PaintHooks.asm.  They are already written and they work, they just need to be included in the build system.
Comment 1 Alex Christensen 2013-07-19 18:26:46 PDT
Created attachment 207163 [details]
Patch
Comment 2 Build Bot 2013-07-19 21:34:53 PDT
Comment on attachment 207163 [details]
Patch

Attachment 207163 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1132336

New failing tests:
svg/batik/filters/feTile.svg
Comment 3 Build Bot 2013-07-19 21:34:54 PDT
Created attachment 207179 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.3
Comment 4 Brent Fulgham 2013-07-22 10:48:42 PDT
Comment on attachment 207163 [details]
Patch

r=me.
Comment 5 Brent Fulgham 2013-07-22 10:49:16 PDT
(In reply to comment #2)
> (From update of attachment 207163 [details])
> Attachment 207163 [details] did not pass mac-ews (mac):
> Output: http://webkit-queues.appspot.com/results/1132336
> 
> New failing tests:
> svg/batik/filters/feTile.svg

It is not possible for the Visual Studio project file change to make the Mac EWS fail a test.
Comment 6 Brent Fulgham 2013-07-22 10:49:35 PDT
(In reply to comment #3)
> Created an attachment (id=207179) [details]
> Archive of layout-test-results from webkit-ews-01 for mac-mountainlion
> 
> The attached test failures were seen while running run-webkit-tests on the mac-ews.
> Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

It is not possible for the Visual Studio project file change to make the Mac EWS fail a test.
Comment 7 WebKit Commit Bot 2013-07-22 11:11:01 PDT
Comment on attachment 207163 [details]
Patch

Clearing flags on attachment: 207163

Committed r152982: <http://trac.webkit.org/changeset/152982>
Comment 8 WebKit Commit Bot 2013-07-22 11:11:03 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Brent Fulgham 2013-11-18 17:26:12 PST
<rdar://problem/15498697>