Bug 118930 - Extract computeRenderStyleForProperty and nodeOrItsAncestorNeedsStyleRecalc from ComputedStyleExtractor::propertyValue
Summary: Extract computeRenderStyleForProperty and nodeOrItsAncestorNeedsStyleRecalc f...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 118618 118032
  Show dependency tree / graph
 
Reported: 2013-07-19 17:16 PDT by Ryosuke Niwa
Modified: 2013-07-19 19:58 PDT (History)
10 users (show)

See Also:

Attachments
Cleanup (4.62 KB, patch)
2013-07-19 17:21 PDT, Ryosuke Niwa 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-07-19 17:16:09 PDT 
We need to cleanup the function before we can fix the bug 118618.
Comment 1 Ryosuke Niwa 2013-07-19 17:21:23 PDT 
Created attachment 207160 [details]
Cleanup
Comment 2 Andreas Kling 2013-07-19 17:50:07 PDT 
Comment on attachment 207160 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=207160&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1576
> +    for (Node* n = styledNode; n && !needsStyleRecalc; n = n->parentNode()) // FIXME: Call parentOrShadowHostNode() instead
> +        needsStyleRecalc = n->needsStyleRecalc();
> +    return needsStyleRecalc;

We should just return (true) immediately if we encounter an ancestor that needs style recalc.
Comment 3 Ryosuke Niwa 2013-07-19 19:58:18 PDT 
Committed r152938: <http://trac.webkit.org/changeset/152938>