RESOLVED FIXED 118930
Extract computeRenderStyleForProperty and nodeOrItsAncestorNeedsStyleRecalc from ComputedStyleExtractor::propertyValue 
https://bugs.webkit.org/show_bug.cgi?id=118930
Summary Extract computeRenderStyleForProperty and nodeOrItsAncestorNeedsStyleRecalc f...
Ryosuke Niwa
Reported 2013-07-19 17:16:09 PDT
We need to cleanup the function before we can fix the bug 118618.
Attachments
Cleanup (4.62 KB, patch)
2013-07-19 17:21 PDT, Ryosuke Niwa 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-07-19 17:21:23 PDT
Created attachment 207160 [details] Cleanup
Andreas Kling
Comment 2 2013-07-19 17:50:07 PDT
Comment on attachment 207160 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=207160&action=review > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1576 > + for (Node* n = styledNode; n && !needsStyleRecalc; n = n->parentNode()) // FIXME: Call parentOrShadowHostNode() instead > + needsStyleRecalc = n->needsStyleRecalc(); > + return needsStyleRecalc; We should just return (true) immediately if we encounter an ancestor that needs style recalc.
Ryosuke Niwa
Comment 3 2013-07-19 19:58:18 PDT
Committed r152938: <http://trac.webkit.org/changeset/152938>
Note You need to log in before you can comment on or make changes to this bug.