Bug 118924 - AX: VoiceOver not detecting misspelled words doesn't work in all cases
Summary: AX: VoiceOver not detecting misspelled words doesn't work in all cases
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-07-19 14:59 PDT by chris fleizach
Modified: 2013-07-19 20:36 PDT (History)
10 users (show)

See Also:

Attachments
patch (3.95 KB, patch)
2013-07-19 15:16 PDT, chris fleizach 		buildbot: commit-queue-
Details | Formatted Diff | Diff
patch (4.35 KB, patch)
2013-07-19 15:27 PDT, chris fleizach 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2013-07-19 14:59:36 PDT 
WebCore needs to update to use the NSAccessibilityMarkedMisspelledTextAttribute
Comment 1 Radar WebKit Bug Importer 2013-07-19 15:00:41 PDT 
<rdar://problem/14497952>
Comment 2 chris fleizach 2013-07-19 15:16:07 PDT 
Created attachment 207152 [details]
patch
Comment 3 Build Bot 2013-07-19 15:18:39 PDT 
Comment on attachment 207152 [details]
patch

Attachment 207152 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1134005
Comment 4 Build Bot 2013-07-19 15:21:20 PDT 
Comment on attachment 207152 [details]
patch

Attachment 207152 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1132268
Comment 5 chris fleizach 2013-07-19 15:27:03 PDT 
Created attachment 207154 [details]
patch
Comment 6 Tim Horton 2013-07-19 17:11:43 PDT 
Comment on attachment 207154 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207154&action=review

> Tools/ChangeLog:8
> +        Make the misspelled detection dependent on both types of attributes to be present.

Grammar. s/to be/being/, I think.

> Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:909
> +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED > 1080

We almost universally use >= and the version that it was first introduced in. You should do the same.

> Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:911
> +    if (misspelled)
> +        misspelled = [[attrs objectForKey:NSAccessibilityMarkedMisspelledTextAttribute] boolValue];

This looks funny but is fine.
Comment 7 chris fleizach 2013-07-19 20:36:37 PDT 
http://trac.webkit.org/changeset/152939