Bug 118923 - JIT::updateTopCallFrame doesn't update the CallFrame's bytecodeOffset if bytecodeOffset == 0
Summary: JIT::updateTopCallFrame doesn't update the CallFrame's bytecodeOffset if byte...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
Depends on:
Reported: 2013-07-19 14:55 PDT by Mark Hahnenberg
Modified: 2013-07-24 12:55 PDT (History)
1 user (show)

See Also:

Patch (1.73 KB, patch)
2013-07-22 15:15 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-07-19 14:55:51 PDT
This causes the CallFrame's bytecodeOffset to not be properly set when we enter, e.g., cti_optimize from an op_enter.
Comment 1 Mark Hahnenberg 2013-07-19 14:56:45 PDT
This isn't currently a big deal since cti_optimize takes the bytecode offset as its argument, but it will be important for bytecode-liveness-based JSStack scans for GC.
Comment 2 Mark Hahnenberg 2013-07-22 15:15:09 PDT
Created attachment 207285 [details]
Comment 3 WebKit Commit Bot 2013-07-24 12:55:43 PDT
Comment on attachment 207285 [details]

Clearing flags on attachment: 207285

Committed r153097: <http://trac.webkit.org/changeset/153097>
Comment 4 WebKit Commit Bot 2013-07-24 12:55:45 PDT
All reviewed patches have been landed.  Closing bug.