Bug 118911 - fourthTier: Structure::isValidOffset() should be able to tell you if you're loading a valid JSValue, and not just not crashing
Summary: fourthTier: Structure::isValidOffset() should be able to tell you if you're l...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-19 11:18 PDT by Filip Pizlo
Modified: 2013-07-19 19:52 PDT (History)
7 users (show)

See Also:

Attachments
the patch (1.57 KB, patch)
2013-07-19 11:19 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-07-19 11:18:35 PDT 
We could also have a separate method like "willNotCrash(offset)", but that's not what isValidOffset() is intended to mean.
Comment 1 Filip Pizlo 2013-07-19 11:19:43 PDT 
Created attachment 207127 [details]
the patch
Comment 2 Geoffrey Garen 2013-07-19 13:39:23 PDT 
Comment on attachment 207127 [details]
the patch

r=me
Comment 3 Filip Pizlo 2013-07-19 19:52:32 PDT 
Landed in http://trac.webkit.org/changeset/152937