UNCONFIRMED 118899
Remove the CUSTOM_SCHEME_HANDLER macro. 
https://bugs.webkit.org/show_bug.cgi?id=118899
Summary Remove the CUSTOM_SCHEME_HANDLER macro.
Sanghyun Park
Reported 2013-07-19 05:44:15 PDT
Now, CUSTOM_SCHEME_HANDLER and NAVIGATOR_CONTENT_UTILS macros are applied in NavigatorContentUtils[1]. I think that applying two macros in one interface is not necessary. How about use only NAVIGATOR_CONTENT_UTILS rather than use both flags? [1] http://www.w3.org/TR/html51/webappapis.html#custom-handlers
Attachments
Patch (72.30 KB, patch)
2013-07-19 07:49 PDT, Sanghyun Park 		no flags
DetailsFormatted DiffDiff
Patch (62.58 KB, patch)
2013-07-19 08:31 PDT, Sanghyun Park 		beidson: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sanghyun Park
Comment 1 2013-07-19 07:49:55 PDT
Created attachment 207094 [details] Patch
Sanghyun Park
Comment 2 2013-07-19 08:31:26 PDT
Created attachment 207095 [details] Patch
Gyuyoung Kim
Comment 3 2013-11-15 00:07:55 PST
Comment on attachment 207095 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207095&action=review It looks you need to do rebase based on latest WebKit trunk. > Tools/ChangeLog:8 > + Remove the CUSTOM_SCHEME_HANDLER macro, becuase Applying two macros in NavigatorContentUtils interface is not necessary. typo. becuase Applying -> because applying ?
Brady Eidson
Comment 4 2016-05-24 22:01:55 PDT
Comment on attachment 207095 [details] Patch Assuming that patches for review since 2013 are stale, r-
Note You need to log in before you can comment on or make changes to this bug.