Bug 118899 - Remove the CUSTOM_SCHEME_HANDLER macro.
Summary: Remove the CUSTOM_SCHEME_HANDLER macro.
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-19 05:44 PDT by Sanghyun Park
Modified: 2016-05-24 22:01 PDT (History)
7 users (show)

See Also:

Attachments
Patch (72.30 KB, patch)
2013-07-19 07:49 PDT, Sanghyun Park 		no flags Details | Formatted Diff | Diff
Patch (62.58 KB, patch)
2013-07-19 08:31 PDT, Sanghyun Park 		beidson: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sanghyun Park 2013-07-19 05:44:15 PDT 
Now, CUSTOM_SCHEME_HANDLER and NAVIGATOR_CONTENT_UTILS macros are applied in NavigatorContentUtils[1]. 
I think that applying two macros in one interface is not necessary.
How about use only NAVIGATOR_CONTENT_UTILS rather than use both flags?

[1] http://www.w3.org/TR/html51/webappapis.html#custom-handlers
Comment 1 Sanghyun Park 2013-07-19 07:49:55 PDT 
Created attachment 207094 [details]
Patch
Comment 2 Sanghyun Park 2013-07-19 08:31:26 PDT 
Created attachment 207095 [details]
Patch
Comment 3 Gyuyoung Kim 2013-11-15 00:07:55 PST 
Comment on attachment 207095 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207095&action=review

It looks you need to do rebase based on latest WebKit trunk.

> Tools/ChangeLog:8
> +        Remove the CUSTOM_SCHEME_HANDLER macro, becuase Applying two macros in NavigatorContentUtils interface is not necessary.

typo. becuase Applying -> because applying ?
Comment 4 Brady Eidson 2016-05-24 22:01:55 PDT 
Comment on attachment 207095 [details]
Patch

Assuming that patches for review since 2013 are stale, r-