Bug 118889 - HTMLKeygenElement should use didAddUserAgentShadowRoot and not create subclasses of HTMLSelectElement
Summary: HTMLKeygenElement should use didAddUserAgentShadowRoot and not create subclas...
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: BlinkMergeCandidate
Depends on:
Reported: 2013-07-18 22:03 PDT by Ryosuke Niwa
Modified: 2019-08-16 17:20 PDT (History)
3 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-07-18 22:03:28 PDT
Consider merging https://chromium.googlesource.com/chromium/blink/+/edf5d89706a067cce8891ffe2e24005a6e076031

HTMLKeygenElement was manually managing the UserAgent ShadowRoot instead of using
the "framework" with didAddUserAgentShadowRoot. It also created a subclass of
HTMLSelectElement just to set the pseudoId on it to "-webkit-keygen-select". We
can remove that and then make HTMLSelectElement FINAL.
Comment 1 Ryosuke Niwa 2019-08-16 17:20:55 PDT
We should just remove this comment in https://bugs.webkit.org/show_bug.cgi?id=167018 instead.