Bug 118885 - String::lower() - Skip to slow path on the first failure
Summary: String::lower() - Skip to slow path on the first failure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-18 20:56 PDT by Benjamin Poulain
Modified: 2013-08-09 15:07 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.07 KB, patch)
2013-07-18 20:58 PDT, Benjamin Poulain 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-07-18 20:56:03 PDT 
String::lower() - Skip to slow patch on the first failure
Comment 1 Benjamin Poulain 2013-07-18 20:58:18 PDT 
Created attachment 207055 [details]
Patch
Comment 2 Benjamin Poulain 2013-07-22 15:01:21 PDT 
Comment on attachment 207055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207055&action=review

> Source/WTF/ChangeLog:3
> +        String::lower() - Skip to slow patch on the first failure

Note to self: fix the changlog!
Comment 3 Benjamin Poulain 2013-07-22 15:29:29 PDT 
Committed r153007: <http://trac.webkit.org/changeset/153007>
Comment 4 Darin Adler 2013-08-09 13:55:49 PDT 
Did this slow down the “already all lowercase” case? How did you measure that?
Comment 5 Benjamin Poulain 2013-08-09 15:07:59 PDT 
(In reply to comment #4)
> Did this slow down the “already all lowercase” case?

I could not measure any difference for the fast path on x86_64 and ARM.

> How did you measure that?

Through the JS API with String.toLowerCase() with an ad-hoc benchmark.