Bug 118873 – Use explicit HTMLFrameElementBase cast and introduce toHTMLFrameElementBase

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Kangil Han]

Use explicit HTMLFrameElementBase cast

[Kangil Han]

Created attachment 207039 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 207039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207039&action=review

> Source/WebCore/ChangeLog:9
> +        It should be HTMLFrameElementBase that embraces both HTMLFrameElement and HTMLIFrameElement.
> +        This also makes correct toFooElement possible.

Can we also fix RenderLayer::scrollRectToVisible not to cast the pointer to HTMLFrameElement?

[Ryosuke Niwa]

I also think it'll be valuable to add toHTMLFrameElementBase calls in the same patch.

[Kangil Han]

Created attachment 207045 [details]
Patch

[Kangil Han]

Took Ryosuke's comment into consideration.

[Ryosuke Niwa]

Comment on attachment 207045 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207045&action=review

> Source/WebCore/rendering/RenderLayer.cpp:2267
> -static inline bool frameElementAndViewPermitScroll(HTMLFrameElement* frameElement, FrameView* frameView) 
> +static inline bool frameElementAndViewPermitScroll(HTMLFrameElementBase* frameElementBase, FrameView* frameView) 

What I meant to say is that we should fix the caller of this function where we're incorrectly casting HTMLIFrameElement to HTMLFrameElement.

[Ryosuke Niwa]

Comment on attachment 207045 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207045&action=review

> Source/WebCore/rendering/RenderFrameBase.cpp:76
> -    HTMLFrameElementBase* element = static_cast<HTMLFrameElementBase*>(node());
> +    HTMLFrameElementBase* element = toHTMLFrameElementBase(node());
>      bool isScrollable = element->scrollingMode() != ScrollbarAlwaysOff;

It seems like this local variable is used only once. You might as well as do:
toHTMLFrameElementBase(node())->scrollingMode() != ScrollbarAlwaysOff
instead.

[Kangil Han]

Created attachment 207058 [details]
Patch

[Kangil Han]

Took Ryosuke's comment into consideration.

[WebKit Commit Bot]

Comment on attachment 207058 [details]
Patch

Clearing flags on attachment: 207058

Committed r152889: <http://trac.webkit.org/changeset/152889>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.