Bug 118867 - fourthTier: DFG shouldn't create CheckStructures for array accesses except if the ArrayMode implies an original array access
Summary: fourthTier: DFG shouldn't create CheckStructures for array accesses except if...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 118866
  Show dependency treegraph
 
Reported: 2013-07-18 15:16 PDT by Filip Pizlo
Modified: 2013-07-18 16:31 PDT (History)
7 users (show)

See Also:


Attachments
the patch (17.43 KB, patch)
2013-07-18 15:17 PDT, Filip Pizlo
mhahnenberg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-07-18 15:16:14 PDT
This allows us to kill off a bunch of code in the parser, in fixup, and to simplify ArrayProfile.

It also makes it easier to ask any array-using node how to create its type check.
Comment 1 Filip Pizlo 2013-07-18 15:17:46 PDT
Created attachment 207028 [details]
the patch
Comment 2 Mark Hahnenberg 2013-07-18 15:23:08 PDT
Comment on attachment 207028 [details]
the patch

r=me
Comment 3 Filip Pizlo 2013-07-18 16:31:21 PDT
Landed in http://trac.webkit.org/changeset/152872