Bug 118864 – Fix painting and hit testing issues with various pagination and writing mode combinations

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Dave Hyatt]

Fix painting and hit testing issues with various pagination and writing mode combinations

[Dave Hyatt]

Created attachment 207025 [details]
Patch that gets all combinations of lr/rl pagination and writing modes working.

Not ready for review, since I want to do a bunch of cleanup on this to not do the delta computations in every place, etc.

[Dave Hyatt]

Notes to self:
(1) Move WebCore::paginationModeForRenderStyle(style) into RenderStyle.
(2) Don't need to set the column gap again when the writing mode propagates.
(3) Direction propagating doesn't affect column styles so I only needed to check for writing mode changes.
(4) Make helper functions to set your initial logical top offset and to compute the block delta. ColumnInfo is a good place for those.
(5) Back out Beth and Tim's patch, since it doesn't matter now.
(6) Start testing other combinations. Only combinations tested so far are all the lr/rl combinations. That's 4 out of 16, so I need to just test the rest and make sure they all work.
(7) Test cases. Need real pagination API test cases. Do layout tests have support for the API?

[David Kilzer (:ddkilzer)]

<rdar://problem/14109351>

[Dave Hyatt]

Created attachment 207097 [details]
Patch that contains code changes

[Dave Hyatt]

Created attachment 207098 [details]
LeftToRight Pagination Mode Tests

[WebKit Commit Bot]

Attachment 207097 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/style/RenderStyle.cpp', u'Source/WebCore/rendering/style/RenderStyle.h']" exit_code: 1
Source/WebCore/rendering/RenderBlock.cpp:3089:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/rendering/RenderBlock.cpp:3101:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/rendering/RenderLayer.cpp:4343:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 207099 [details]
RightToLeft Layout Tests

[Dave Hyatt]

Created attachment 207100 [details]
TopToBottom Layout Tests

[Dave Hyatt]

Created attachment 207101 [details]
BottomToTop Layout Tests

[Dave Hyatt]

Created attachment 207102 [details]
Other Layout Test changes

[Tim Horton]

Comment on attachment 207097 [details]
Patch that contains code changes

View in context: https://bugs.webkit.org/attachment.cgi?id=207097&action=review

> Source/WebCore/ChangeLog:17
> +        This patch also backs out the maximumScrollPosition change, since it only occurred because

Yay! But, please mention the commit #.

[Dave Hyatt]

Created attachment 207103 [details]
Code changes only (should pass style queue now)

[Build Bot]

Comment on attachment 207099 [details]
RightToLeft Layout Tests

Attachment 207099 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1101853

New failing tests:
fast/multicol/pagination/RightToLeft-lr.html
fast/multicol/pagination/RightToLeft-rl.html

[Build Bot]

Created attachment 207104 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3

[Build Bot]

Comment on attachment 207099 [details]
RightToLeft Layout Tests

Attachment 207099 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1104883

New failing tests:
media/video-zoom.html
fast/multicol/pagination/RightToLeft-lr.html
fast/multicol/pagination/RightToLeft-rl.html

[Build Bot]

Created attachment 207105 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Dave Hyatt]

Created attachment 207106 [details]
Code changes only

[Build Bot]

Comment on attachment 207101 [details]
BottomToTop Layout Tests

Attachment 207101 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1100835

New failing tests:
fast/multicol/pagination/BottomToTop-tb.html
fast/multicol/pagination/BottomToTop-bt.html

[Build Bot]

Created attachment 207113 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Build Bot]

Comment on attachment 207098 [details]
LeftToRight Pagination Mode Tests

Attachment 207098 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1106907

New failing tests:
fast/multicol/pagination/LeftToRight-rl.html
fast/multicol/pagination/LeftToRight-lr.html

[Build Bot]

Created attachment 207121 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Build Bot]

Comment on attachment 207100 [details]
TopToBottom Layout Tests

Attachment 207100 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1104896

New failing tests:
fast/multicol/pagination/TopToBottom-bt.html
fast/multicol/pagination/TopToBottom-tb.html

[Build Bot]

Created attachment 207123 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Build Bot]

Comment on attachment 207102 [details]
Other Layout Test changes

Attachment 207102 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1096904

New failing tests:
fast/multicol/shrink-to-column-height-for-pagination.html
svg/batik/text/smallFonts.svg

[Build Bot]

Created attachment 207128 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Dave Hyatt]

Landed in r152911.