Bug 118858 - New PDFPlugin doesn't support WebKitOmitPDFSupport, acts as if Plug-ins are off
: New PDFPlugin doesn't support WebKitOmitPDFSupport, acts as if Plug-ins are off
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2013-07-18 11:26 PST by
Modified: 2013-07-18 15:57 PST (History)


Attachments
Patch (3.19 KB, patch)
2013-07-18 11:28 PST, Jer Noble
eric.carlson: review+
buildbot: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
Patch for committing. (3.21 KB, patch)
2013-07-18 13:32 PST, Jer Noble
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2013-07-18 11:26:56 PST
New PDFPlugin doesn't support WebKitOmitPDFSupport, acts as if Plug-ins are off
------- Comment #1 From 2013-07-18 11:28:23 PST -------
Created an attachment (id=207004) [details]
Patch
------- Comment #2 From 2013-07-18 11:48:20 PST -------
(From update of attachment 207004 [details])
Attachment 207004 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1095562
------- Comment #3 From 2013-07-18 12:04:45 PST -------
(From update of attachment 207004 [details])
Attachment 207004 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1090969
------- Comment #4 From 2013-07-18 13:32:04 PST -------
Created an attachment (id=207015) [details]
Patch for committing.
------- Comment #5 From 2013-07-18 14:56:46 PST -------
(From update of attachment 207015 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=207015&action=review

> Source/WebCore/ChangeLog:3
> +        New PDFPlugin doesn't support WebKitOmitPDFSupport, acts as if Plug-ins are off

Does it not? I think that it might be reading defaults from a different process though.
------- Comment #6 From 2013-07-18 14:59:27 PST -------
(From update of attachment 207015 [details])
Clearing flags on attachment: 207015

Committed r152867: <http://trac.webkit.org/changeset/152867>
------- Comment #7 From 2013-07-18 15:01:22 PST -------
Cleared cq flag for discussion, but it was too late to stop the queue. Would also like new PDFPlugin author to weigh in.
------- Comment #8 From 2013-07-18 15:03:12 PST -------
(In reply to comment #5)
> (From update of attachment 207015 [details] [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207015&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        New PDFPlugin doesn't support WebKitOmitPDFSupport, acts as if Plug-ins are off
> 
> Does it not? I think that it might be reading defaults from a different process though.

We're not reading the defaults from different processes. See <rdar://problem/13478932> for discussion.
------- Comment #9 From 2013-07-18 15:05:58 PST -------
Thanks, jer!
------- Comment #10 From 2013-07-18 15:41:23 PST -------
> We're not reading the defaults from different processes. See <rdar://problem/13478932> for discussion.

So what are we doing in WebPage::platformPreferencesDidChange()?

    BOOL omitPDFSupport = [[NSUserDefaults standardUserDefaults] boolForKey:@"WebKitOmitPDFSupport"];
------- Comment #11 From 2013-07-18 15:57:33 PST -------
(In reply to comment #10)
> > We're not reading the defaults from different processes. See <rdar://problem/13478932> for discussion.
> 
> So what are we doing in WebPage::platformPreferencesDidChange()?
> 
>     BOOL omitPDFSupport = [[NSUserDefaults standardUserDefaults] boolForKey:@"WebKitOmitPDFSupport"];

That code is not in the tree anymore: http://trac.webkit.org/changeset/152841/trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm