Bug 118858 - New PDFPlugin doesn't support WebKitOmitPDFSupport, acts as if Plug-ins are off
Summary: New PDFPlugin doesn't support WebKitOmitPDFSupport, acts as if Plug-ins are off
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-18 11:26 PDT by Jer Noble
Modified: 2013-07-18 15:57 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.19 KB, patch)
2013-07-18 11:28 PDT, Jer Noble 		eric.carlson: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Patch for committing. (3.21 KB, patch)
2013-07-18 13:32 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2013-07-18 11:26:56 PDT 
New PDFPlugin doesn't support WebKitOmitPDFSupport, acts as if Plug-ins are off
Comment 1 Jer Noble 2013-07-18 11:28:23 PDT 
Created attachment 207004 [details]
Patch
Comment 2 Build Bot 2013-07-18 11:48:20 PDT 
Comment on attachment 207004 [details]
Patch

Attachment 207004 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1095562
Comment 3 Build Bot 2013-07-18 12:04:45 PDT 
Comment on attachment 207004 [details]
Patch

Attachment 207004 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1090969
Comment 4 Jer Noble 2013-07-18 13:32:04 PDT 
Created attachment 207015 [details]
Patch for committing.
Comment 5 Alexey Proskuryakov 2013-07-18 14:56:46 PDT 
Comment on attachment 207015 [details]
Patch for committing.

View in context: https://bugs.webkit.org/attachment.cgi?id=207015&action=review

> Source/WebCore/ChangeLog:3
> +        New PDFPlugin doesn't support WebKitOmitPDFSupport, acts as if Plug-ins are off

Does it not? I think that it might be reading defaults from a different process though.
Comment 6 WebKit Commit Bot 2013-07-18 14:59:27 PDT 
Comment on attachment 207015 [details]
Patch for committing.

Clearing flags on attachment: 207015

Committed r152867: <http://trac.webkit.org/changeset/152867>
Comment 7 Alexey Proskuryakov 2013-07-18 15:01:22 PDT 
Cleared cq flag for discussion, but it was too late to stop the queue. Would also like new PDFPlugin author to weigh in.
Comment 8 Tim Horton 2013-07-18 15:03:12 PDT 
(In reply to comment #5)
> (From update of attachment 207015 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207015&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        New PDFPlugin doesn't support WebKitOmitPDFSupport, acts as if Plug-ins are off
> 
> Does it not? I think that it might be reading defaults from a different process though.

We're not reading the defaults from different processes. See <rdar://problem/13478932> for discussion.
Comment 9 Tim Horton 2013-07-18 15:05:58 PDT 
Thanks, jer!
Comment 10 Alexey Proskuryakov 2013-07-18 15:41:23 PDT 
> We're not reading the defaults from different processes. See <rdar://problem/13478932> for discussion.

So what are we doing in WebPage::platformPreferencesDidChange()?

    BOOL omitPDFSupport = [[NSUserDefaults standardUserDefaults] boolForKey:@"WebKitOmitPDFSupport"];
Comment 11 Tim Horton 2013-07-18 15:57:33 PDT 
(In reply to comment #10)
> > We're not reading the defaults from different processes. See <rdar://problem/13478932> for discussion.
> 
> So what are we doing in WebPage::platformPreferencesDidChange()?
> 
>     BOOL omitPDFSupport = [[NSUserDefaults standardUserDefaults] boolForKey:@"WebKitOmitPDFSupport"];

That code is not in the tree anymore: http://trac.webkit.org/changeset/152841/trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm