Bug 118854 – REGRESSION (r132678): Tests that use SSL or port 8080 time out when run using old-run-webkit-tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Daniel Bates]

HTTP tests that use SSL (port 8443) and port 8080 time out when run using old-run-webkit-tests following <http://trac.webkit.org/changeset/132678> (bug #98602) because Apache no longer listens to ports 8443 (SSL) and 8080 by default. Instead we need to update Tools/Scripts/old-run-webkit-tests to explicitly tell Apache to listen on these ports.

[Daniel Bates]

<rdar://problem/14081339>

[Daniel Bates]

Created attachment 206997 [details]
Patch

[David Kilzer (:ddkilzer)]

Comment on attachment 206997 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206997&action=review

r=me

> Tools/Scripts/old-run-webkit-tests:1586
> +        "-c", "ErrorLog \"$absTestResultsDirectory/error_log.txt\""

Nit:  I'm a fan of leaving the comma at the end in case more lines are added later, but it's not required to land this.

[Daniel Bates]

(In reply to comment #3)
> [...]
> > Tools/Scripts/old-run-webkit-tests:1586
> > +        "-c", "ErrorLog \"$absTestResultsDirectory/error_log.txt\""
> 
> Nit:  I'm a fan of leaving the comma at the end in case more lines are added later, but it's not required to land this.

Will add a comma to the end of this line before I land this patch.

[Dirk Pranke]

I'm almost afraid to ask this, but who still cares about old-run-webkit-tests and why ? (This is not meant as a slanted question, I'm wondering if there are still reasons why people might want to run it instead of NRWT). 

AFAIK the only reason missing functionality still in ORWT at this point is maybe for the Qt Mac port ?

[Daniel Bates]

Committed r152852: <http://trac.webkit.org/changeset/152852>

[Daniel Bates]

(In reply to comment #5)
> I'm almost afraid to ask this, but who still cares about old-run-webkit-tests and why ? (This is not meant as a slanted question, I'm wondering if there are still reasons why people might want to run it instead of NRWT). 
> 
> AFAIK the only reason missing functionality still in ORWT at this point is maybe for the Qt Mac port ?

The iOS WebKit port uses old-run-webkit-tests at the time of writing.

[Dirk Pranke]

(In reply to comment #7)
> The iOS WebKit port uses old-run-webkit-tests at the time of writing.

I see. Are there changes to support iOS in ORWT that aren't upstreamed? I don't see any mention of ios in either old-run-webkit-tests or webkitdirs.pm, so it's hard for me to say what would be needed to make NRWT work with it (though I would hope very little). Though this is clearly a separate issue ...

[Daniel Bates]

(In reply to comment #8)
> (In reply to comment #7)
> > The iOS WebKit port uses old-run-webkit-tests at the time of writing.
> 
> I see. Are there changes to support iOS in ORWT that aren't upstreamed?

Yes. We're looking to either upstream these changes or, even better, switch to new-run-webkit-tests.