Update update-webkit-localizable-strings to use extract-localizable-js-strings for the WebInspectorUI strings.
Created attachment 206992 [details] Patch
Comment on attachment 206992 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206992&action=review r=me > Tools/Scripts/extract-localizable-js-strings:59 > + $file =~ s-^./--; I have never seen "-" used as the s/// delimiter. It is kind of confusing. Typically I see / or | used. Also, is this trying to detect a literal '.' or a single character directory? Seems like this should be $file =~ s|^\./||; > Tools/Scripts/extract-localizable-strings:46 > +no warnings 'deprecated'; Why is this needed and not needed before? > Tools/Scripts/update-webkit-localizable-strings:42 > +my $webInspectorUIFileToUpdate = "../OpenSource/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js"; I suspect the "../OpenSource/" part of this path should be removed.
(In reply to comment #2) > (From update of attachment 206992 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=206992&action=review > > r=me > > > Tools/Scripts/extract-localizable-js-strings:59 > > + $file =~ s-^./--; > > I have never seen "-" used as the s/// delimiter. It is kind of confusing. Typically I see / or | used. > > Also, is this trying to detect a literal '.' or a single character directory? Seems like this should be > > $file =~ s|^\./||; Matches extract-localizable-strings and works, so I'll keep it as-is. > > Tools/Scripts/extract-localizable-strings:46 > > +no warnings 'deprecated'; > > Why is this needed and not needed before? Prevents error spew hen running update-webkit-localizable-strings that we were just tolerating. So I did this drive-by fix. > > Tools/Scripts/update-webkit-localizable-strings:42 > > +my $webInspectorUIFileToUpdate = "../OpenSource/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js"; > > I suspect the "../OpenSource/" part of this path should be removed. Yep, fixed.
http://trac.webkit.org/changeset/152870