Bug 118848 - Use [ImplementedAs] instead of special casing in the bindings generators
Summary: Use [ImplementedAs] instead of special casing in the bindings generators
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-07-18 06:20 PDT by Chris Dumez
Modified: 2013-07-18 07:23 PDT (History)
10 users (show)

See Also:

Attachments
Patch (18.89 KB, patch)
2013-07-18 06:24 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-07-18 06:20:52 PDT 
In several instances, special casing is used in the bindings generator to avoid name clashes in the implementation. The [ImplementedBy] IDL extended attribute is meant to solve this issue so we should use it instead.

Corresponding Blink revisions:
https://src.chromium.org/viewvc/blink?revision=154303&view=revision
https://src.chromium.org/viewvc/blink?revision=154309&view=revision
https://src.chromium.org/viewvc/blink?revision=154341&view=revision
Comment 1 Chris Dumez 2013-07-18 06:24:11 PDT 
Created attachment 206987 [details]
Patch
Comment 2 Kentaro Hara 2013-07-18 06:29:55 PDT 
Comment on attachment 206987 [details]
Patch

Looks like a good refactoring.
Comment 3 WebKit Commit Bot 2013-07-18 07:23:37 PDT 
Comment on attachment 206987 [details]
Patch

Clearing flags on attachment: 206987

Committed r152844: <http://trac.webkit.org/changeset/152844>
Comment 4 WebKit Commit Bot 2013-07-18 07:23:39 PDT 
All reviewed patches have been landed.  Closing bug.