WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
118848
Use [ImplementedAs] instead of special casing in the bindings generators
https://bugs.webkit.org/show_bug.cgi?id=118848
Summary
Use [ImplementedAs] instead of special casing in the bindings generators
Chris Dumez
Reported
2013-07-18 06:20:52 PDT
In several instances, special casing is used in the bindings generator to avoid name clashes in the implementation. The [ImplementedBy] IDL extended attribute is meant to solve this issue so we should use it instead. Corresponding Blink revisions:
https://src.chromium.org/viewvc/blink?revision=154303&view=revision
https://src.chromium.org/viewvc/blink?revision=154309&view=revision
https://src.chromium.org/viewvc/blink?revision=154341&view=revision
Attachments
Patch
(18.89 KB, patch)
2013-07-18 06:24 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2013-07-18 06:24:11 PDT
Created
attachment 206987
[details]
Patch
Kentaro Hara
Comment 2
2013-07-18 06:29:55 PDT
Comment on
attachment 206987
[details]
Patch Looks like a good refactoring.
WebKit Commit Bot
Comment 3
2013-07-18 07:23:37 PDT
Comment on
attachment 206987
[details]
Patch Clearing flags on attachment: 206987 Committed
r152844
: <
http://trac.webkit.org/changeset/152844
>
WebKit Commit Bot
Comment 4
2013-07-18 07:23:39 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug